Conversation
1. Root cause: m_sidebar is initialized to nullptr and the same function already guards with "if (m_sidebar && ...)" at line 1776, but the changeResetModelData() call at line 1800 omits the null check, causing a potential null pointer dereference 2. Fix: add "if (m_sidebar)" guard before calling changeResetModelData() to skip the call when sidebar is null 3. Impact: no behavior change when sidebar is non-null; prevents crash when sidebar pointer is null during document close path Influence: 1. Test opening and closing documents with sidebar visible 2. Test closing documents when sidebar is not initialized 3. Verify no regression on annotation save and bookmark persistence fix: 修复关闭文档路径中侧边栏空指针解引用 1. 根因：m_sidebar 初始化为 nullptr，同函数第 1776 行已有 "if (m_sidebar && ...)" 守卫，但第 1800 行调用 changeResetModelData() 时遗漏空检查，存在空指针解引用风险 2. 方案：在调用 changeResetModelData() 前增加 "if (m_sidebar)" 守卫，指针为空时跳过调用 3. 影响：侧边栏非空时行为不变；侧边栏为空时避免崩溃 Influence: 1. 测试侧边栏可见时打开和关闭文档 2. 测试侧边栏未初始化时关闭文档 3. 验证批注保存和书签持久化无回归 PMS: BUG-213
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 3 days and 17 hours by commenting @sourcery-ai review. Upgrade to get a review now.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a null guard around the sidebar reset-model update in DocSheet::setAlive(bool) so closing a document without an initialized sidebar no longer risks a crash, while retaining existing behavior and persistence flows when the sidebar exists. Sequence diagram for guarded document close persistencesequenceDiagram
participant DocSheet
participant Renderer
participant Sidebar
participant Database
DocSheet->>Renderer: save()
Renderer-->>DocSheet: success
alt sidebar exists
DocSheet->>Sidebar: changeResetModelData()
end
DocSheet->>Database: saveBookmarks(filePath(), m_bookmarks)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto reviewAI 代码审查报告
总体评价
总体评价结论: 代码审查通过 本次提交修复了 维度1：语法逻辑（25/25）✓评价: 语法正确，逻辑清晰 分析
维度2：代码质量（25/25）✓评价: 代码结构清晰，注释完整 分析
维度3：代码性能（20/20）✓评价: 性能良好，资源使用合理 分析
维度4：代码安全（30/30）✓评价: 存在0个安全漏洞 分析
漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个修改文件清单
修改详情文件: // 修改前:
m_sidebar->changeResetModelData();
// 修改后:
if (m_sidebar) {
m_sidebar->changeResetModelData();
}根因分析: 修复方案: 在调用 审查结论本次提交是一个精确的空指针解引用修复，代码变更最小化，与同函数已有的防御性编程模式一致。commit message 清晰描述了根因、修复方案和影响范围。代码审查通过，无安全问题，无性能问题，无质量问题。 |
2 participants
fix: guard null sidebar pointer in setAlive close path
function already guards with "if (m_sidebar && ...)" at line
1776, but the changeResetModelData() call at line 1800 omits
the null check, causing a potential null pointer dereference
changeResetModelData() to skip the call when sidebar is null
crash when sidebar pointer is null during document close path
Influence:
fix: 修复关闭文档路径中侧边栏空指针解引用
"if (m_sidebar && ...)" 守卫，但第 1800 行调用
changeResetModelData() 时遗漏空检查，存在空指针解引用风险
守卫，指针为空时跳过调用
Influence:
PMS: BUG-213
Summary by Sourcery
Bug Fixes: