fix(gui): use server-owned proactive delegation presets - #3993
Conversation
(cherry picked from commit 481edbb) (cherry picked from commit 24977adf223210dbf68cfb5d626916f97b47ed9a)
(cherry picked from commit 6fb0fc6) (cherry picked from commit 21757b71a6007d217ef1f383c739cfc6618fd8e9)
Document the carried v2 wrapper and replay contract while preserving native and legacy policy history. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> (cherry picked from commit 8000e2482fb06567ac3d3e3474c54c5a4468d92f)
(cherry picked from commit db502d4) (cherry picked from commit 5b60a4fa70aa5ef34ba043065961d5ea0042b780)
Document response-only recommendations, explicit-write legacy normalization and current-server dashboard draft ownership. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> (cherry picked from commit e5a6f35b8d82387703958188f4fcbaacb8eec892)
|
✅ Deterministic PR hygiene checks passed. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 55 / 80이 PR은 bug6 스택 4/6층입니다. base가 #3992 head( 코드는 토글/에디터가
라인 SubagentDelegationSection.tsx - ULTRA_MODE_PRESET 상수 삭제. recommendation 없으면 on 토글·Restore disabled 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Summary
The dashboard duplicated a delegation preset and could reinstall outdated instructions. Use the current server's recommendation when a user explicitly enables or restores the preset, now labelled Always proactive delegation. Missing or malformed recommendations disable installation and restoration while preserving custom editing and clearing; switching servers hides the previous hint and blocks stale writes.
Carries #3951 at
db502d486c8d8de80c0143fcfd6f86238d1ce917, preserving all nine GUI locales and five guides. GET/unrelated updates do not migrate stored hints. Only explicit writes exactly matching either released legacy preset canonicalize; other custom text stays byte-identical. Restore edits a draft, and Save persists it.Manual stack, layer 4 of 6, depends on #3992: Go compatibility → xAI child result → V2 guidance → server preset → canonical reset alias → cooldown recovery. Review only this layer; merge bottom-up through dev.
Verification
--no-verify.b0bc09ba867906375e52cf0180caa4ea4ea95bea, against synthetic local API responses. Verified enable, exact custom Save, Restore-without-write, Clear, missing/malformed recommendation, error/retry, distinct server recommendation and keyboard focus. No actual account, settings or native delegation was exercised.727683f44e9f1daa9b6b1e2dbf93167e4ce30cc1; it remains pending.Checklist
Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com
Maintainer integration decision
The owner explicitly authorized bottom-up integration of this manual stack into
dev. Acting as current maintainerlidge-jun, I choose the dev-only maintainer-integration path in MAINTAINERS.md; this is not self-approval. Independent technical/security review and contributor attribution remain required, and any maintainer objection must be resolved.This PR's certified candidate head is
727683f44e9f1daa9b6b1e2dbf93167e4ce30cc1with PR CI34185870948. Cumulative integration headf80f39d20e8395901d3b62758d118ea3a559a9f4contains current dev402be7c1f88283eb8465c3aec8437ccecd2542ec; full lane=all run34193218874 is the required final matrix. PR CI34193213502 attempt2 passed after one investigated macOS job cancellation; the full dispatch reran only its failed macOS control after same-head shard evidence passed. Failed attempts remain recorded. These links identify the exact evidence to inspect; any pending, failed, cancelled or skipped required execution blocks landing. The actor, base, head, reviews and checks will be refreshed immediately before each merge.Serial merge prediction is conflict-free and its final tree equals the cumulative candidate. Because merged branches are automatically deleted, the next owned child is retargeted to dev immediately before its parent lands. PRs remain ordinary/manual; no native stack registration is requested. Local product checks remain NOT RUN by owner instruction.
Final pre-landing verification: full run34193218874 attempt2 SUCCESS, all26 named jobs and mandatory execution steps verified at
f80f39d20e8395901d3b62758d118ea3a559a9f4; PR run34193213502 attempt2 SUCCESS. The investigation allowed one retry of each failed/cancelled macOS job; prior failures remain historical, and previously passing jobs were not rerun. Current CI is accepted for this owner-authorized integration.