fix(codex): separate proxy V2 guidance from native policy - #3992
Conversation
Refs #3907. Enable exact string preservation through the existing agent-message normalizer only for non-forward xAI destinations. Keep array conversion and mixed-ciphertext fail-closed behavior unchanged. Add adapter destination controls and mocked parent/child/result continuation coverage for SSE and JSON. This is an isolated WP2 preparation candidate; local product tests, typecheck, build, install and runtime probes were NOT RUN. Main owns phase adoption, independent audit and hosted CI. (cherry picked from commit 339e42c1e388db1ca01cda9d960368ad9335d48c)
(cherry picked from commit 481edbb) (cherry picked from commit 24977adf223210dbf68cfb5d626916f97b47ed9a)
(cherry picked from commit 6fb0fc6) (cherry picked from commit 21757b71a6007d217ef1f383c739cfc6618fd8e9)
Document the carried v2 wrapper and replay contract while preserving native and legacy policy history. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> (cherry picked from commit 8000e2482fb06567ac3d3e3474c54c5a4468d92f)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 58 / 80이 PR은 bug6 수동 스택 3/6층입니다. base는 변경 핵심은 CI는 대체로 녹색(test/gates/hygiene/enforce-target pass)입니다. draft이고 base가 라인 src/server/responses/collaboration.ts 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Summary
OpenCodex's V2 routing guidance used the same wrapper as native Codex delegation policy. Give newly generated proxy guidance its own
opencodex_subagent_guidancewrapper and keep the built-in text advisory. Replay deduplication compares the latest exact text separately for proxy and native tag families, preserving built-in → custom → built-in transitions.Carries #3944 from
481edbbd8a853c4155db9c40f76e432f9001b2d2and6fb0fc6f1d34c77b98a74fe817e5bd90063a7d1a, including original regression coverage and five localized guides. V1, native/legacy history and custom body contents remain intact. Tags classify replay text; they do not authenticate historical authorship or revoke prior instructions.Manual stack, layer 3 of 6, depends on #3991: Go compatibility → xAI child result → V2 guidance → server preset → canonical reset alias → cooldown recovery. Review this layer only; merge bottom-up through dev.
Verification
--no-verify.Checklist
Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com
Maintainer integration decision
The owner explicitly authorized bottom-up integration of this manual stack into
dev. Acting as current maintainerlidge-jun, I choose the dev-only maintainer-integration path in MAINTAINERS.md; this is not self-approval. Independent technical/security review and contributor attribution remain required, and any maintainer objection must be resolved.This PR's certified candidate head is
3ceef0121712b290c3d4443e9fc3f0a04cecead6with PR CI34181398746. Cumulative integration headf80f39d20e8395901d3b62758d118ea3a559a9f4contains current dev402be7c1f88283eb8465c3aec8437ccecd2542ec; full lane=all run34193218874 is the required final matrix. PR CI34193213502 attempt2 passed after one investigated macOS job cancellation; the full dispatch reran only its failed macOS control after same-head shard evidence passed. Failed attempts remain recorded. These links identify the exact evidence to inspect; any pending, failed, cancelled or skipped required execution blocks landing. The actor, base, head, reviews and checks will be refreshed immediately before each merge.Serial merge prediction is conflict-free and its final tree equals the cumulative candidate. Because merged branches are automatically deleted, the next owned child is retargeted to dev immediately before its parent lands. PRs remain ordinary/manual; no native stack registration is requested. Local product checks remain NOT RUN by owner instruction.
Final pre-landing verification: full run34193218874 attempt2 SUCCESS, all26 named jobs and mandatory execution steps verified at
f80f39d20e8395901d3b62758d118ea3a559a9f4; PR run34193213502 attempt2 SUCCESS. The investigation allowed one retry of each failed/cancelled macOS job; prior failures remain historical, and previously passing jobs were not rerun. Current CI is accepted for this owner-authorized integration.