fix(gui): separate fallback choices from the refreshed subagent roster - #3931
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change separates roster availability from fallback discovery availability. ChangesFallback availability separation
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
A stale cached fallback availability list could hide new models from the main Subagents roster when the auxiliary fallback request failed. Keep roster availability separate and pass fallback availability only into the fallback editor.
Adds regression scenarios with cached [a], fresh roster [a,b], and either fallback 503 or independently successful fallback discovery. This is a pre-publication follow-up to #3927.
Verification
GUI layout is unchanged; prior mocked failure-path capture for the same workspace:

Checklist
Maintainer integration: exact head 0d7652a passed Cross-platform CI34147331533 and prior independent source re-review. Remote macmini-cf used project Bun1.4.0,44 focused tests passed; no local tests/build/install/typecheck were run. The scope helper confirms current maintainer authority and no outstanding maintainer objection. Integrate through the owner-authorized release task; any subsequent automatic review findings will be checked before publication.
Summary by CodeRabbit
Bug Fixes
Tests