Skip to content

fix(gui): separate fallback choices from the refreshed subagent roster - #3931

Merged
lidge-jun merged 3 commits into
devfrom
codex/release-247-roster-fix
Sep 7, 2026
Merged

fix(gui): separate fallback choices from the refreshed subagent roster#3931
lidge-jun merged 3 commits into
devfrom
codex/release-247-roster-fix

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

A stale cached fallback availability list could hide new models from the main Subagents roster when the auxiliary fallback request failed. Keep roster availability separate and pass fallback availability only into the fallback editor.

Adds regression scenarios with cached [a], fresh roster [a,b], and either fallback 503 or independently successful fallback discovery. This is a pre-publication follow-up to #3927.

Verification

  • Independent source re-review requested.
  • Local tests, builds, typechecks and installs NOT RUN per owner instruction. Hosted CI is the verification gate.
  • Only three files change; no credentials or routing behavior changes.

GUI layout is unchanged; prior mocked failure-path capture for the same workspace:
Fallback failure with usable roster

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed; this restores the documented independent-loading contract.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Maintainer integration: exact head 0d7652a passed Cross-platform CI34147331533 and prior independent source re-review. Remote macmini-cf used project Bun1.4.0,44 focused tests passed; no local tests/build/install/typecheck were run. The scope helper confirms current maintainer authority and no outstanding maintainer objection. Integrate through the owner-authorized release task; any subsequent automatic review findings will be checked before publication.

Summary by CodeRabbit

  • Bug Fixes

    • Kept current roster availability separate from fallback model discovery, preventing stale fallback data from affecting fresh choices.
    • Fallback controls now remain disabled when model discovery is unavailable.
    • Saving fallback selections now commits only the models selected in the fallback picker.
  • Tests

    • Added coverage for successful and failed model discovery scenarios to verify fallback selection behavior.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2d132ddd-3ac4-48fd-9113-959fe1b70417

📥 Commits

Reviewing files that changed from the base of the PR and between 2abf071 and 0d7652a.

📒 Files selected for processing (3)
  • gui/src/components/subagents-workspace/SubagentsWorkspace.tsx
  • gui/src/pages/Subagents.tsx
  • gui/tests/subagents-fallback.test.tsx

📝 Walkthrough

Walkthrough

The change separates roster availability from fallback discovery availability. SubagentsWorkspace forwards the distinct lists to fallback controls, and tests cover discovery failures, successful filtering, saving, and cache fixtures.

Changes

Fallback availability separation

Layer / File(s) Summary
Separate model availability wiring
gui/src/components/subagents-workspace/SubagentsWorkspace.tsx, gui/src/pages/Subagents.tsx
At lines 35, 68, and 252, SubagentsWorkspace accepts fallbackAvailable and passes it to SubagentDelegationSection. At lines 323–324, Subagents.tsx passes roster available and fallback discovery results separately.
Fallback discovery and save coverage
gui/tests/subagents-fallback.test.tsx
Lines 311–356 test 503 and 200 discovery responses. Lines 653–660 add fallbackAvailable to committed cache fixtures.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-247-roster-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun marked this pull request as ready for review September 7, 2026 17:34
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 7, 2026 17:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T17:36:42.830815Z 0d7652a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant