Skip to content

release: apply final roster correction to main - #3933

Merged
lidge-jun merged 6 commits into
mainfrom
codex/release-247-main-final
Sep 7, 2026
Merged

release: apply final roster correction to main#3933
lidge-jun merged 6 commits into
mainfrom
codex/release-247-main-final

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Bring the pre-publication roster cache correction from #3931 into main. The main roster keeps its own fresh discovery list; fallback availability is used only for fallback controls. No version change and no sponsor placement.

The owner authorized these release promotions. Depends on #3931 landing in dev; the prepared tree matches its candidate except the channel version.

Verification

  • Three-file source correction with stale-cache/fallback-failure regression scenarios.
  • Local suites/typechecks/builds/installs NOT RUN per owner; hosted CI only.
  • Previous regression repairs passed independent Astra review; this follow-up receives independent source re-review and fresh hosted checks.
  • Publication still requires this final promotion SHA's push CI, service lifecycle and all-lanes Windows/macOS control verification, then release dry-run.
  • Expected enforce-target wrong-base is the previously declared owner-authorized release promotion exception; it is not reported as passing and no policies are disabled.

GUI layout unchanged; earlier mocked workspace failure-state evidence:
Subagent workspace

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Bug Fixes
    • Improved model selection behavior in the subagents workspace by keeping currently available models separate from fallback models.
    • Prevented cached or fallback model results from replacing fresh model availability.
    • Preserved correct model choices when fallback discovery fails or returns no configured models.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 127f2617-49cf-47bd-b1e0-75cc11abd71a

📥 Commits

Reviewing files that changed from the base of the PR and between 6f71931 and 947bae9.

📒 Files selected for processing (3)
  • gui/src/components/subagents-workspace/SubagentsWorkspace.tsx
  • gui/src/pages/Subagents.tsx
  • gui/tests/subagents-fallback.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change separates the available model roster from fallback discovery data. The workspace uses the fallback list only for fallback choices. Tests cover failed and empty fallback discovery while preserving roster edits and saved configuration.

Changes

Fallback model routing

Layer / File(s) Summary
Separate model-list wiring
gui/src/components/subagents-workspace/SubagentsWorkspace.tsx, gui/src/pages/Subagents.tsx
SubagentsWorkspace accepts fallbackAvailable separately from available. The delegation section uses fallbackAvailable when present and otherwise uses available.
Cached fallback regression coverage
gui/tests/subagents-fallback.test.tsx
Parameterized tests cover 503 and successful empty fallback discovery. Fixtures now include fallbackAvailable in the committed cache shape.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 947ba

This correction keeps the primary model roster available when fallback discovery is stale, empty, or unavailable, while limiting fallback controls to their own availability data. No concrete current-head merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the release promotion of the final roster correction to main. It matches the changes that separate fresh roster availability from fallback availability and is specific e…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-247-main-final

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title release: apply final roster correction to main [WRONG BRANCH] release: apply final roster correction to main Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

Hygiene

Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun marked this pull request as ready for review September 7, 2026 17:39
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 7, 2026 17:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T17:43:14.541120Z 947bae9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit f7f890f into main Sep 7, 2026
31 of 36 checks passed
@lidge-jun
lidge-jun deleted the codex/release-247-main-final branch September 7, 2026 17:41
@lidge-jun lidge-jun changed the title [WRONG BRANCH] release: apply final roster correction to main release: apply final roster correction to main Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant