feat(engine): transaction family — topic cancel/reactivate, inbox lifecycle, scoped commit#386
Open
leeovery wants to merge 5 commits into
Open
feat(engine): transaction family — topic cancel/reactivate, inbox lifecycle, scoped commit#386leeovery wants to merge 5 commits into
leeovery wants to merge 5 commits into
Conversation
leeovery
added a commit
that referenced
this pull request
Jun 12, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Multi-step state changes previously hand-orchestrated across several tool
calls become single engine commands that are atomic from the caller's
perspective and report what they did in one decision-ready JSON line.
- kernel/git.cjs: scoped stage+commit (clean index reports null, never fails)
- domain/transitions.cjs: epic topic cancel/reactivate — manifest write,
KB sync as warn-don't-block warnings, scoped conventional commit
- domain/inbox.cjs: archive/restore/delete sets with strict path validation
and the existing inbox commit-message forms
- engine commit {wu}|--inbox -m: the scoped commit helper
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Covers topic cancel/reactivate (manifest fields, discovery order drop, commit messages, KB warn-don't-block with no KB configured), inbox archive/restore/delete (single and multi, message forms, strict path rejections, all-or-nothing validation), and engine commit (scoped stage, clean-tree null, --inbox, argument validation). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sections E and F collapse their hand-orchestrated manifest writes, KB sync, and commit into one engine command each; the KB warning block now renders only when the response carries warnings. Frontmatter gains the engine CLI allowance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ctions The working-set archive and the archived-view restore/delete flows each become one engine command — file moves and the set-scoped commit included. Frontmatter gains the engine CLI allowance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The session-loop write commit and the pivot/reroute commit blocks call the scoped commit helper; messages unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
leeovery
force-pushed
the
feat/engine-transactions
branch
from
8dc30a4 to
fc23854
Compare
This was referenced Jun 12, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 4 of the engine stack (on #385). The multi-step state changes Claude hand-executed across 3–5 tool calls each — with prose-specified error tolerance — become single engine commands with decision-ready JSON responses.
engine topic cancel/reactivate— the five-step epic flows (stash status → set cancelled → drop map order → KB remove → scoped commit; and the reverse with re-indexing). KB steps are warn-don't-block, reported in the response'swarnings; the .md renders the warning block only when present. The read-previous_status-and-pipe-it-back-by-hand plumbing is gone.engine inbox archive/restore/delete— the working-set and archived-view transactions (mkdir/mv/git rm + scoped commit), strict all-or-nothing path validation, existing commit-message conventions preserved.engine commit {wu} -m …(+--inbox) — scoped stage+commit helper; clean tree returns ok/nothing-to-commit. Wired into discussion-session's commit sites.kernel/git.cjs— scoped stage+commit as mechanism (no workflow vocabulary); domain rings compose it.Bash(mv .workflows/.inbox/)andBash(git rm)in workflow-start are now call-site-free and can be dropped in a later cleanup).Judgment calls to review
discussion({wu}/{topic}): {what changed}(step 5 previously had no template; prefix derived from the existing F-block messages).commitScopedstages the pathspec then commits the index — pre-staged unrelated changes ride along, identical to the previous hand-rungit add -- … && git commitbehaviour.lib.cjsexports for transitions/inbox — consumers are CLI-only skill prose (added when a real consumer lands).Tests
98/98 (
npm test, +16 transaction tests on hermetic temp-dir git fixtures — KB warn-don't-block proven against an unconfigured fixture); epic discovery suite 98/98 unchanged; migration 045 15/15; typecheck clean.🤖 Generated with Claude Code