feat(engine): boot pipeline — Step 0 checks in one decision-ready call#389
Open
leeovery wants to merge 2 commits into
Open
feat(engine): boot pipeline — Step 0 checks in one decision-ready call#389leeovery wants to merge 2 commits into
leeovery wants to merge 2 commits into
Conversation
…ne call engine boot runs migrate.sh (hard error on failure — migrations never half-run silently), then knowledge check, then compact when ready (warn-don't-block), answering with one decision-ready JSON line. migrations.changed mirrors migrate.sh's own files-updated stop-gate signal; the trimmed report keeps the update counts. commit gains a --workflows scope staging the whole tree — migrations touch many work units plus .workflows/.state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… stop inline Steps 0.2 (migrations) and 0.3 (knowledge check) now branch on one engine boot call instead of orchestrating migrate.sh, knowledge check, and compact across separate commands. The conversational pieces keep their exact display formats and STOP semantics: the migration summary and review gate move in from the migrate skill (commit lands via engine commit --workflows), the not-ready terminal stop moves in from knowledge-check.md. The migrate skill's SKILL.md becomes an internal note — its scripts stay, invoked by engine boot. Allowed-tools: git add/commit/rm dropped (no call sites remain), git diff added for the migration review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 7 of the engine stack (on #388). The boot check pipeline (moment-class 11 in the design log) becomes code.
engine boot— runs migrate.sh +knowledge check+knowledge compact(when ready) in one call, returning{migrations:{changed, output}, knowledge, compacted, warnings}. migrate.sh failure is a hard error (migrations never half-run silently); compact failures warn-don't-block.changedis derived from migrate.sh's own stop-gate marker, deliberately notgit status(pre-existing session dirt under.workflowswould false-positive — reasoning documented in boot.cjs).engine commit --workflows— whole-.workflowsscope for the migration commit./workflow-migrateretired to an internal note — survey confirmed workflow-start was its sole invoker;scripts/migrate.sh+migrations/stay (now invoked by boot). CLAUDE.md/CONVENTIONS.md dev docs re-pointed.git add/git commit/git rmdropped from workflow-start (zero call sites — routed through the engine since feat(engine): transaction family — topic cancel/reactivate, inbox lifecycle, scoped commit #386);git diffadded.Flags for review
knowledge-check.mdnow has zero skill loaders (left intact per scope; candidate for retirement in a later cleanup).compacted: boolonly) — minor informational loss.Tests
117/117 (10 new boot tests — hermetic stub-script layout exercising real
__dirnameresolution, plus one real-migrations integration test asserting idempotentchanged: falseon second run); start 56/56 and epic 98/98 unchanged; typecheck clean.🤖 Generated with Claude Code