Skip to content

feat: link live.lean-lang.org to comparator.live.lean-lang.org feat: link live.lean-lang.org to comparator.live.lean-lang.org#11

Merged
robsimmons merged 2 commits into
nixos-settingsfrom
nixos-comparator-2
Jun 11, 2026
Merged

feat: link live.lean-lang.org to comparator.live.lean-lang.org feat: link live.lean-lang.org to comparator.live.lean-lang.org#11
robsimmons merged 2 commits into
nixos-settingsfrom
nixos-comparator-2

Conversation

@robsimmons

@robsimmons robsimmons commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This PR creates a configurable button, "Can I Trust This Proof", that loads the current code in Comparator Live:

image

Loading the website from a non-safelisted referrer link (or with no referrer link) will generate a pop-up warning. This warning is pretty dismissable: it has ClickAway behavior, it can be dismissed with an X, and the "Don't show this again" button permanently dismisses it.

image

or, in light mode:

image

The semantics of this setting need to be different from the other user settings— we do NOT want a url to be able to dismiss this warning, and we DO always want it to be saved in local storage or else the "Dismiss permanently" option is a lie. This is the same semantics used for hiding the navbar, as introduced in #10, so we add it to that part of the settings menu. Most people will interact with via the in-popup option.

image

@robsimmons robsimmons force-pushed the nixos-comparator-2 branch from cebf111 to 4d4ef64 Compare June 9, 2026 22:31
@robsimmons robsimmons merged commit 43100b4 into nixos-settings Jun 11, 2026
2 of 5 checks passed
robsimmons added a commit that referenced this pull request Jun 11, 2026
@robsimmons robsimmons deleted the nixos-comparator-2 branch June 12, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant