feat: link live.lean-lang.org to comparator.live.lean-lang.org#9
Closed
robsimmons wants to merge 3 commits into
Closed
feat: link live.lean-lang.org to comparator.live.lean-lang.org#9robsimmons wants to merge 3 commits into
robsimmons wants to merge 3 commits into
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a configurable button, "Can I Trust This Proof", that loads the current code in Comparator Live:
Loading the website from a non-safelisted referrer link (or with no referrer link) will generate a pop-up warning. This warning is pretty dismissable: it has ClickAway behavior, it can be dismissed with an X, and the "Don't show this again" button permanently dismisses it.
or, in light mode:
Because the semantics of this setting need to be different from the other user settings — we do NOT want a url to be able to dismiss this warning, and we DO always want it to be saved in local storage or else the "Dismiss permanently" option is a lie, this is configured in a new "Local Settings" portion of the configuration menu. Not ideal, but seemed like a reasonable tradeoff. Most people will interact with it via the in-popup option.