Skip to content

fix: Map the WRONG_TYPE error kind to TYPE_MISMATCH #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinyoklion wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −0
Open

fix: Map the WRONG_TYPE error kind to TYPE_MISMATCH #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a718e
fix: Map wrong type evaluation errors to type mismatch
devin-ai-integration[bot] Aug 31, 2026
7fe8ed8
style: Import the evaluation detail class in the test
devin-ai-integration[bot] Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ResolutionDetailsConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ private static function errorKindToCode(?string $errorKind): ResolutionError
return new ResolutionError(ErrorCode::PARSE_ERROR());
case EvaluationReason::USER_NOT_SPECIFIED_ERROR:
return new ResolutionError(ErrorCode::TARGETING_KEY_MISSING());
case EvaluationReason::WRONG_TYPE_ERROR:
return new ResolutionError(ErrorCode::TYPE_MISMATCH());
case EvaluationReason::EXCEPTION_ERROR:
// intentional fallthrough
default:
Expand Down
17 changes: 17 additions & 0 deletions tests/ProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@

namespace LaunchDarkly\Tests;

use LaunchDarkly\EvaluationDetail;
use LaunchDarkly\EvaluationReason;
use LaunchDarkly\Integrations;
use LaunchDarkly\OpenFeature\Provider;
use LaunchDarkly\OpenFeature\ResolutionDetailsConverter;
use OpenFeature\implementation\flags\Attributes;
use OpenFeature\implementation\flags\EvaluationContext;
use OpenFeature\interfaces\provider\ErrorCode;
Expand Down Expand Up @@ -66,6 +68,21 @@ public function testEvaluationErrorResultsAreConvertedCorrectly(): void
$this->assertEquals(ErrorCode::FLAG_NOT_FOUND(), $error->getResolutionErrorCode());
}

public function testWrongTypeEvaluationErrorsAreConvertedCorrectly(): void
{
$evaluation = new EvaluationDetail(
true,
null,
EvaluationReason::error(EvaluationReason::WRONG_TYPE_ERROR)
);
$resolutionDetails = (new ResolutionDetailsConverter())->toResolutionDetails($evaluation);

$this->assertEquals(Reason::ERROR, $resolutionDetails->getReason());
/** @var ResolutionError */
$error = $resolutionDetails->getError();
$this->assertEquals(ErrorCode::TYPE_MISMATCH(), $error->getResolutionErrorCode());
}

public function testInvalidTypesGenerateTypeMismatchResults(): void
{
$td = new Integrations\TestData();
Expand Down
Loading