fix: Map the WRONG_TYPE error kind to TYPE_MISMATCH - #27
Open
kinyoklion wants to merge 2 commits into
Open
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps the LaunchDarkly
WRONG_TYPEevaluation error kind to the OpenFeatureTYPE_MISMATCHerror code.GENERAL, so an application could not distinguish a flag whose type does not match the requested one from any other evaluation error.OFPrequirement 3.2.3 prescribes this mapping, and the Java, .NET, Python, Ruby and JavaScript providers all implement it.Implementation details
Requirements
Related issues
None. The same gap was fixed this week in openfeature-python-server#57 and js-core#1888.
Describe the solution you've provided
ResolutionDetailsConverter::errorKindToCodegains the missing case. The LaunchDarkly PHP SDK reports this kind when a flag's value does not match the requested type, which OpenFeature represents asTYPE_MISMATCH.Describe alternatives you've considered
None; the mapping is prescribed by the provider spec.
Testing
make check(composer cs-check,composer phpstan,composer phpunit). The new test drives the converter directly, since the provider's own type checking intercepts most mismatches before the SDK reports this kind.Link to Devin session: https://app.devin.ai/sessions/38a6eaf69fcf41109e136a1d0fe5e899
Open in Devin Desktop: https://app.devin.ai/desktop/session/38a6eaf69fcf41109e136a1d0fe5e899?variant=devin
Requested by: @kinyoklion
Note
Overview
When the LaunchDarkly SDK returns an evaluation error with kind
WRONG_TYPE_ERROR, the OpenFeature provider now surfacesTYPE_MISMATCHinstead of the genericGENERALcode.ResolutionDetailsConverter::errorKindToCodegains the missing switch case so callers can tell a wrong flag type apart from other evaluation failures, matching OpenFeature provider spec 3.2.3 and the other LaunchDarkly OpenFeature SDKs.A new unit test exercises the converter directly with
EvaluationReason::error(WRONG_TYPE_ERROR)and assertsReason::ERRORplusErrorCode::TYPE_MISMATCH().Reviewed by Cursor Bugbot for commit 7fe8ed8. Bugbot is set up for automated code reviews on this repo. Configure here.