Skip to content

fix(sdk): resolve home via platform APIs #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samzong merged 1 commit into from
Aug 4, 2026
Merged

fix(sdk): resolve home via platform APIs #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rust/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,11 @@ fn expand_host_path(path: &str, home: &Path, cwd: &Path) -> PathBuf {
fn defaults(options: &BaseOptions) -> io::Result<(PathBuf, PathBuf)> {
let home = match &options.home {
Some(home) => home.clone(),
None => PathBuf::from(std::env::var("HOME").unwrap_or_default()),
None => PathBuf::from(
std::env::var("HOME")
.or_else(|_| std::env::var("USERPROFILE"))
.unwrap_or_default(),
),
};
let cwd = match &options.cwd {
Some(cwd) => cwd.clone(),
Expand Down
5 changes: 3 additions & 2 deletions ts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
stat,
writeFile,
} from "node:fs/promises";
import { homedir } from "node:os";
import { dirname, join, relative, resolve, sep } from "node:path";
import { fileURLToPath } from "node:url";
import { defaultHostsSpecJson } from "./hosts.generated.js";
Expand Down Expand Up @@ -415,7 +416,7 @@ export async function detectHosts(
options: BaseOptions & { scope?: Scope } = {},
): Promise<Host[]> {
const spec = await loadHostSpec(options.hostsFile);
const home = options.home ?? process.env.HOME ?? "";
const home = options.home ?? homedir();
const cwd = options.cwd ?? process.cwd();
const detected: Host[] = [];

Expand Down Expand Up @@ -678,7 +679,7 @@ export async function resolveInstallTargets(
detectedHostIds: string[];
}> {
const spec = await loadHostSpec(options.hostsFile);
const home = options.home ?? process.env.HOME ?? "";
const home = options.home ?? homedir();
Comment thread
samzong marked this conversation as resolved.
const cwd = options.cwd ?? process.cwd();
const agents = options.agents ?? defaultAgents;
const resolved =
Expand Down
Loading