fix(sdk): resolve home via platform APIs - #24
Merged
Conversation
Use os.homedir() in TypeScript and HOME/USERPROFILE fallback in Rust so host path expansion works on Windows without relying on HOME alone. ## Considered and deferred - testdata/cases [BOT-SCOPE]: Default-home / Windows USERPROFILE path is not covered by golden cases; fixtures inject home explicitly and adding cases is outside this commit's file set. - rust/src/lib.rs:1471 [BOT-NIT]: HOME/USERPROFILE env fallback is shallower than Go os.UserHomeDir (go/kitup.go:1262) and Python Path.home (python/src/kitup/hosts.py:64); Rust std has no home API and a new crate is out of scope. - ts/src/index.ts:419 [BOT-NIT]: os.homedir() can throw when home is unresolvable vs previous empty-string fallback; empty home previously produced wrong ~/ expansion, so throw is acceptable platform behavior. Signed-off-by: samzong <samzong.lu@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a966ec353
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.homedir()in TypeScript andHOME/USERPROFILEfallback in Rust so user-scope host paths work on Windows withoutHOME.os.UserHomeDir) and Python (Path.home) defaults; golden cases still injecthomeand stay unchanged.Scope Check
spec/hosts.jsonchanges.Verification
make checkConsidered and deferred