Skip to content

fix: HPA metrics + PDB selector, and add missing config options #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidusken wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: HPA metrics + PDB selector, and add missing config options #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd9cfb
chore(kellnr): add docs bucket configuration to values.yaml and bump …
davidusken Sep 25, 2026
d358a9f
feat(kellnr): enhance proxy and GCS configuration options in values.y…
davidusken Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kellnr/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 6.1.8
version: 6.2.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
54 changes: 54 additions & 0 deletions charts/kellnr/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,21 @@ KELLNR_PROXY__NUM_THREADS: {{ .Values.kellnr.proxy.numThreads | quote }}
{{ if not (eq .Values.kellnr.proxy.downloadOnUpdate nil) }}
KELLNR_PROXY__DOWNLOAD_ON_UPDATE: {{ .Values.kellnr.proxy.downloadOnUpdate | quote }}
{{ end }}
{{ if .Values.kellnr.proxy.url }}
KELLNR_PROXY__URL: {{ .Values.kellnr.proxy.url | quote }}
{{ end }}
{{ if .Values.kellnr.proxy.index }}
KELLNR_PROXY__INDEX: {{ .Values.kellnr.proxy.index | quote }}
{{ end }}
{{ if .Values.kellnr.proxy.api }}
KELLNR_PROXY__API: {{ .Values.kellnr.proxy.api | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.proxy.connectTimeoutSeconds nil) }}
KELLNR_PROXY__CONNECT_TIMEOUT_SECONDS: {{ .Values.kellnr.proxy.connectTimeoutSeconds | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.proxy.requestTimeoutSeconds nil) }}
KELLNR_PROXY__REQUEST_TIMEOUT_SECONDS: {{ .Values.kellnr.proxy.requestTimeoutSeconds | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.proxy.userAgent nil) }}
KELLNR_PROXY__USER_AGENT: {{ .Values.kellnr.proxy.userAgent | quote }}
{{ end }}
Expand Down Expand Up @@ -227,6 +242,39 @@ KELLNR_S3__CRATES_BUCKET: {{ .Values.kellnr.s3.crates_bucket | quote }}
{{ if not (eq .Values.kellnr.s3.cratesio_bucket nil) }}
KELLNR_S3__CRATESIO_BUCKET: {{ .Values.kellnr.s3.cratesio_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.s3.docs_bucket nil) }}
KELLNR_S3__DOCS_BUCKET: {{ .Values.kellnr.s3.docs_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.enabled nil) }}
KELLNR_GCS__ENABLED: {{ .Values.kellnr.gcs.enabled | quote }}
{{ end }}
{{ if .Values.kellnr.gcs.endpoint }}
KELLNR_GCS__ENDPOINT: {{ .Values.kellnr.gcs.endpoint | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.allowHttp nil) }}
KELLNR_GCS__ALLOW_HTTP: {{ .Values.kellnr.gcs.allowHttp | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.skipSignature nil) }}
KELLNR_GCS__SKIP_SIGNATURE: {{ .Values.kellnr.gcs.skipSignature | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.crates_bucket nil) }}
KELLNR_GCS__CRATES_BUCKET: {{ .Values.kellnr.gcs.crates_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.cratesio_bucket nil) }}
KELLNR_GCS__CRATESIO_BUCKET: {{ .Values.kellnr.gcs.cratesio_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.toolchain_bucket nil) }}
KELLNR_GCS__TOOLCHAIN_BUCKET: {{ .Values.kellnr.gcs.toolchain_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.docs_bucket nil) }}
KELLNR_GCS__DOCS_BUCKET: {{ .Values.kellnr.gcs.docs_bucket | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.connectTimeoutSeconds nil) }}
KELLNR_GCS__CONNECT_TIMEOUT_SECONDS: {{ .Values.kellnr.gcs.connectTimeoutSeconds | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.gcs.requestTimeoutSeconds nil) }}
KELLNR_GCS__REQUEST_TIMEOUT_SECONDS: {{ .Values.kellnr.gcs.requestTimeoutSeconds | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.oauth2.enabled nil) }}
KELLNR_OAUTH2__ENABLED: {{ .Values.kellnr.oauth2.enabled | quote }}
{{ end }}
Expand Down Expand Up @@ -260,6 +308,12 @@ KELLNR_OAUTH2__READ_ONLY_GROUP_VALUE: {{ .Values.kellnr.oauth2.readOnlyGroupValu
{{ if not (eq .Values.kellnr.oauth2.buttonText nil) }}
KELLNR_OAUTH2__BUTTON_TEXT: {{ .Values.kellnr.oauth2.buttonText | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.oauth2.enforced nil) }}
KELLNR_OAUTH2__ENFORCED: {{ .Values.kellnr.oauth2.enforced | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.oauth2.autoRedirect nil) }}
KELLNR_OAUTH2__AUTO_REDIRECT: {{ .Values.kellnr.oauth2.autoRedirect | quote }}
{{ end }}
{{ if not (eq .Values.kellnr.toolchain.enabled nil) }}
KELLNR_TOOLCHAIN__ENABLED: {{ .Values.kellnr.toolchain.enabled | quote }}
{{ end }}
Expand Down
4 changes: 2 additions & 2 deletions charts/kellnr/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ spec:
minReplicas: {{ .Values.autoscaling.minReplicas }}
maxReplicas: {{ .Values.autoscaling.maxReplicas }}
metrics:
{{- if .Values.autoscaling.targetCPUUtilizationPercentage }}
{{- if .Values.autoscaling.target.CPUUtilizationPercentage }}
- type: Resource
resource:
name: cpu
target:
type: Utilization
averageUtilization: {{ .Values.autoscaling.target.CPUUtilizationPercentage }}
{{- end }}
{{- if .Values.autoscaling.targetMemoryUtilizationPercentage }}
{{- if .Values.autoscaling.target.memoryUtilizationPercentage }}
- type: Resource
resource:
name: memory
Expand Down
2 changes: 1 addition & 1 deletion charts/kellnr/templates/pdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ metadata:
spec:
selector:
matchLabels:
{{- include "kellnr.labels" . | nindent 6 }}
{{- include "kellnr.selectorLabels" . | nindent 6 }}
minAvailable: {{ .Values.pdb.minAvailable }}
{{- end }}
32 changes: 30 additions & 2 deletions charts/kellnr/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,14 @@ kellnr:
maxSize: null # 100
proxy:
enabled: null # false
numThreads: null # 20
numThreads: null # 10
downloadOnUpdate: null # false
# Override to use a crates.io mirror instead of the public crates.io.
url: null # "https://static.crates.io/crates/"
index: null # "https://index.crates.io/"
api: null # "https://crates.io/api/v1/crates/"
connectTimeoutSeconds: null # 5
requestTimeoutSeconds: null # 30
userAgent: null # "kellnr.io/kellnr"
log:
level: null # "info"
Expand Down Expand Up @@ -204,7 +210,21 @@ kellnr:
allowHttp: null # true
crates_bucket: null # "kellnr-crates"
cratesio_bucket: null # "kellnr-cratesio"
toolchain_bucket: null # "kellnr-toolchain"
toolchain_bucket: null # "kellnr-toolchains"
docs_bucket: null # "kellnr-docs"
connectTimeoutSeconds: null # 5
requestTimeoutSeconds: null # 30
gcs:
enabled: null # false
# Custom base URL for a self-hosted or emulator endpoint.
endpoint: ""
allowHttp: null # true
# Skip credential lookup and request signing. Only for unauthenticated endpoints such as emulators.
skipSignature: null # false
crates_bucket: null # "kellnr-crates"
cratesio_bucket: null # "kellnr-cratesio"
toolchain_bucket: null # "kellnr-toolchains"
docs_bucket: null # "kellnr-docs"
connectTimeoutSeconds: null # 5
requestTimeoutSeconds: null # 30

Expand Down Expand Up @@ -240,6 +260,11 @@ kellnr:
readOnlyGroupValue: ""
# Text displayed on the OAuth2 login button
buttonText: null # "Login with SSO"
# Make SSO the only way to log in: disables local username/password login,
# password resets/changes and local user creation. Requires `enabled`.
enforced: null # false
# Skip the login page and redirect straight to the identity provider. Requires `enforced`.
autoRedirect: null # false

toolchain:
enabled: false
Expand Down Expand Up @@ -267,6 +292,9 @@ ingress:
enabled: true
className: ""
annotations: {}
# Path for the Ingress rule and KELLNR_ORIGIN__PATH (sub-path deployments, e.g. "/kellnr").
# Defaults to "/" for the Ingress rule when left empty; KELLNR_ORIGIN__PATH is only set when non-empty.
path: ""
pathType: Prefix
tls:
secretName: "kellnr-cert-secret"
Expand Down
Loading