fix: HPA metrics + PDB selector, and add missing config options - #97
Open
davidusken wants to merge 2 commits into
Open
davidusken wants to merge 2 commits into
davidusken wants to merge 2 commits into
Conversation
…chart version to 6.2.0
…aml; fix HPA and PDB template references
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bugs
Defaults happen to work (the HPA API falls back to 80% CPU), but any custom CPU target and any memory target is silently ignored. Present since 4.2.0.
Missing config
The chart exposed 67 of kellnr's 84 settings. Added the rest: proxy.{url,index,api,connect/requestTimeoutSeconds}, the whole gcs backend (absent despite S3 being supported), and oauth2.{enforced,autoRedirect}. Also fixed the proxy.numThreads comment (said 20, source default is 10) and the singular toolchain_bucket default.