Repository navigation
Add the OV renderer lease and teleop-owned OVXR adapter - #8787
Draft
hougantc-nvda wants to merge 1 commit into
Draft
hougantc-nvda wants to merge 1 commit into
hougantc-nvda wants to merge 1 commit into
Conversation
This was referenced Oct 23, 2026
hougantc-nvda
force-pushed
the
hougantc/kitless-borrowed-renderer
branch
from
October 26, 2026 17:12
9e86c66 to
f63b4c2
Compare
This was referenced Oct 26, 2026
hougantc-nvda
force-pushed
the
hougantc/kitless-borrowed-renderer
branch
from
October 27, 2026 16:08
12208c4 to
6afe08b
Compare
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
hougantc-nvda
force-pushed
the
hougantc/kitless-borrowed-renderer
branch
from
October 29, 2026 02:05
6afe08b to
d6d62fe
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review stack · 1/5: #8787 → #8788 → #8789 → #8790 → #8791
Review only this PR’s changes. The PRs target
main; the comparison isolates this layer from its predecessors.Connect kitless Isaac Lab teleoperation to Isaac Capture's OVXR session using the simulation's existing OVRTX renderer and OVStage. An explicit render lease lets Capture borrow those resources while Lab retains ownership and controls their lifetime.
The responsibilities are:
isaaclab_ov: owns the renderer, stage and scene publication. The generic lease serializes borrowed access without depending on XR or teleoperation.isaaclab_teleop: implements the OVXR adapter inov_libraries_xr.pyand bootstrap inovxr_session.py. It binds the environment, supplies XR render products, publishes scene/anchor updates and coordinates shutdown.Bootstrap reserves the lease before environment construction; the render worker starts afterward. Shutdown stops input consumers, closes the XR session and retires the lease before Lab destroys the renderer/stage. Pre-worker failure releases the lease before the caller closes the environment; interrupted bootstrap construction restores its process state. Failed retirement preserves resources for cleanup by their owning thread. The current lease supports one environment and a private rendering OVStage.
Lease/thread-transfer logic lives in
render_lease.py;publication_buffers.pyretains storage until native writes finish. Ordinary rendering stays inovrtx_renderer.py, with existing public imports preserved. Without a lease, normal rendering continues; while resources are borrowed, conflicting camera rendering, scene writes and destruction are rejected.See OVXR adapter ownership and lifecycle for details.
Dependencies: compatible Isaac Capture OVXR packages and the provider upgrade in #8858. Native-provider defaults are unchanged.
Type of change
Testing
Results cover the cumulative five-PR stack on main
6ef40d19a6f8d3770f86b5c4df3f8ccfb6a25f95. Kitless checks use Isaac Captureae48621f1cc13054c2246210d8f92d30e27fe354built from source using Python 3.12; Kit checks use Lab's upstream locked Capture selection. They are not independent full-repository results for each PR.Limits: these are synthetic IWER checks, not physical-headset acceptance or full task completion. Cold renderer attach, intermittent GR1T2 first-Play recovery and SO101 cube retention remain open. Kit's upstream dependency selection reports nine metadata inconsistencies, including NumPy/Numba; passing the selected Kit tests does not qualify that entire dependency graph. Full-repository, hosted-CI and arm64 coverage are not claimed.
See #8791 for the matched video-rate measurements.
Checklist
pre-commitchecks withuv run isaaclab --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bump package versions — CI handles that)CONTRIBUTORS.mdor my name already exists thereThe warnings checkbox remains open: dependency warnings and the separate Kit metadata audit are unresolved.