Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2acdcda
chore(): add updated snapshots
Ionitron Oct 23, 2026
a9dec5a
Merge branch 'FW-6838-ios-sync-snapshots' of github.com:ionic-team/io…
thetaPC Oct 23, 2026
75e0c4c
chore(): add updated snapshots
Ionitron Oct 23, 2026
cadffc4
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 26, 2026
b3fc869
chore(): add updated snapshots
Ionitron Oct 26, 2026
8eb2a34
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 26, 2026
fb809ed
chore(): add updated snapshots
Ionitron Oct 26, 2026
87fa207
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 26, 2026
1b3e2b7
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 27, 2026
4cc06d7
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 27, 2026
273c4fa
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 27, 2026
9c9575c
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 27, 2026
cf9b856
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 27, 2026
c01d000
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 28, 2026
1f7d23e
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 28, 2026
3a64329
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 28, 2026
2563988
Merge remote-tracking branch 'origin/FW-6838-md-sync-snapshots' into …
thetaPC Oct 28, 2026
cfdf18d
chore(): add updated snapshots
Ionitron Oct 28, 2026
38aa3b9
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 28, 2026
6f239f1
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 28, 2026
e081b71
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 29, 2026
617e149
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 29, 2026
1aacc09
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Oct 29, 2026
38d5372
chore(): add updated snapshots
Ionitron Oct 29, 2026
61a02de
Merge remote-tracking branch 'origin/FW-6838-ios-sync' into FW-6838-i…
thetaPC Nov 5, 2026
e9e2a50
chore(): add updated snapshots
Ionitron Nov 5, 2026
21e1ec4
test(snapshots): restore Firefox snapshots from flaky captures
thetaPC Nov 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At 135% the icon gets a bit smaller, 29x29 down to 27x27. The default scale didn't change, so I think it's the new 1.2em icon size, but is that expected?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected. It isn't the 1.2em icon token: an icon-only icon in ion-buttons stays 1.65em of the button font, and this test renders ion-buttons outside a toolbar, so the button uses the default font size, which went from 16px to 15px in the iOS 17 sync (listed in BREAKING.md). That's the same 15/16 ratio as 29px to 27px, and it shows at 100% too. Inside a toolbar the button keeps 17px, so the icon there is unchanged at both scales.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows the month arrows at full blue while everything else is faded, from the disabled arrow issue on #31645. The readonly snapshots have the gray Cancel and Done too, so these datetime files will need regenerating once those are fixed.

@thetaPC thetaPC Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerated in e9e2a50 now that the #31645 fixes are in. The disabled datetime's arrows are gray with the rest, and the readonly buttons are primary again.

In the readonly snapshot, the next month arrow is disabled on purpose: the test sets max to February 20, so there's no March to go to. next disables it too and shows it faded, and here it uses the new ios disabled color.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About 35 of the files in this PR, like this one, had the same bytes as main before, so their diffs include changes from earlier in the stack and not just the ios sync. They look right, but could you mention that in the PR body so reviewers don't credit them to #31645?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note to the description so reviewers know those diffs come from #31628 and #31636, not this PR.

Loading