Repository navigation
chore(button): update snapshots for the ios sync #31666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2acdcda
a9dec5a
75e0c4c
cadffc4
b3fc869
8eb2a34
fb809ed
87fa207
1b3e2b7
4cc06d7
273c4fa
9c9575c
cf9b856
c01d000
1f7d23e
3a64329
2563988
cfdf18d
38aa3b9
6f239f1
e081b71
617e149
1aacc09
38d5372
61a02de
e9e2a50
21e1ec4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shows the month arrows at full blue while everything else is faded, from the disabled arrow issue on #31645. The readonly snapshots have the gray Cancel and Done too, so these datetime files will need regenerating once those are fixed.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regenerated in e9e2a50 now that the #31645 fixes are in. The disabled datetime's arrows are gray with the rest, and the readonly buttons are primary again. In the readonly snapshot, the next month arrow is disabled on purpose: the test sets |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. About 35 of the files in this PR, like this one, had the same bytes as
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At 135% the icon gets a bit smaller, 29x29 down to 27x27. The default scale didn't change, so I think it's the new 1.2em icon size, but is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected. It isn't the 1.2em icon token: an icon-only icon in
ion-buttonsstays1.65emof the button font, and this test rendersion-buttonsoutside a toolbar, so the button uses the default font size, which went from16pxto15pxin the iOS 17 sync (listed in BREAKING.md). That's the same 15/16 ratio as 29px to 27px, and it shows at 100% too. Inside a toolbar the button keeps17px, so the icon there is unchanged at both scales.