Repository navigation
Conversation
…nic-framework into FW-6838-ios-sync-snapshots
…os-sync-snapshots # Conflicts: # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Safari-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png
…os-sync-snapshots # Conflicts: # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Safari-linux.png
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…FW-6838-ios-sync # Conflicts: # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-ltr-Mobile-Safari-linux.png # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-rtl-Mobile-Chrome-linux.png # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-rtl-Mobile-Firefox-linux.png
…os-sync-snapshots
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 28, 2026
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots # Conflicts: # core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png
ShaneK
requested changes
Nov 2, 2026
Member
There was a problem hiding this comment.
This shows the month arrows at full blue while everything else is faded, from the disabled arrow issue on #31645. The readonly snapshots have the gray Cancel and Done too, so these datetime files will need regenerating once those are fixed.
Member
There was a problem hiding this comment.
About 35 of the files in this PR, like this one, had the same bytes as main before, so their diffs include changes from earlier in the stack and not just the ios sync. They look right, but could you mention that in the PR body so reviewers don't credit them to #31645?
Member
Member
There was a problem hiding this comment.
At 135% the icon gets a bit smaller, 29x29 down to 27x27. The default scale didn't change, so I think it's the new 1.2em icon size, but is that expected?
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The ios button snapshots show the button before the iOS 17 sync in #31645.
What is the new behavior?
Updated ios snapshots for #31645: the new label sizes and weight, smaller icons, gray disabled buttons, icon-sized spinners, and filled pressed outline buttons in toolbars.
Does this introduce a breaking change?
Other information
Only ios snapshots change. md and ionic are untouched.