Skip to content

fix(local): satisfy strictTemplates for keyboard and chat handlers #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sunilsbcloud wants to merge 1 commit into
base: login-refactor
Choose a base branch
from
Open

fix(local): satisfy strictTemplates for keyboard and chat handlers #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions projects/v3/src/app/components/review-list/review-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,19 @@ export class ReviewListComponent implements OnInit, OnChanges, AfterViewInit {
}

// go to the review
goto(review: Review, keyboardEvent?: KeyboardEvent) {
if (keyboardEvent && (keyboardEvent?.code === 'Space' || keyboardEvent?.code === 'Enter')) {
keyboardEvent.preventDefault();
} else if (keyboardEvent) {
return;
goto(review: Review, keyboardEvent?: Event) {
if (keyboardEvent instanceof KeyboardEvent) {
if (keyboardEvent.code === 'Space' || keyboardEvent.code === 'Enter') {
keyboardEvent.preventDefault();
} else {
return;
}
}

this.navigate.emit(review);
}

switchStatus(event: CustomEvent<SegmentChangeEventDetail>) {
switchStatus(event?: CustomEvent<SegmentChangeEventDetail>) {
if (!event) {
return;
}
Expand Down
14 changes: 5 additions & 9 deletions projects/v3/src/app/pages/badges-certificates/badges-certificates.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,11 @@ export class BadgesCertificatesPage implements OnInit, OnDestroy {
this._updatePage();
}

async openBadgeDetail(achievement: Achievement, keyboardEvent?: KeyboardEvent) {
if (
keyboardEvent &&
keyboardEvent.key !== 'Enter' &&
keyboardEvent.key !== ' '
) {
return;
}
if (keyboardEvent) {
async openBadgeDetail(achievement: Achievement, keyboardEvent?: Event) {
if (keyboardEvent instanceof KeyboardEvent) {
if (keyboardEvent.key !== 'Enter' && keyboardEvent.key !== ' ') {
return;
}
keyboardEvent.preventDefault();
}
const modal = await this.modalController.create({
Expand Down
24 changes: 15 additions & 9 deletions projects/v3/src/app/pages/chat/chat-room/chat-room.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,14 +1024,13 @@ export class ChatRoomComponent implements OnInit, OnDestroy, AfterViewInit {
return result;
}

async preview(file, keyboardEvent?: KeyboardEvent) {
if (
keyboardEvent &&
(keyboardEvent?.code === "Space" || keyboardEvent?.code === "Enter")
) {
keyboardEvent.preventDefault();
} else if (keyboardEvent) {
return;
async preview(file, keyboardEvent?: Event) {
if (keyboardEvent instanceof KeyboardEvent) {
if (keyboardEvent.code === "Space" || keyboardEvent.code === "Enter") {
keyboardEvent.preventDefault();
} else {
return;
}
}

const modal = await this.modalController.create({
Expand Down Expand Up @@ -1169,7 +1168,14 @@ export class ChatRoomComponent implements OnInit, OnDestroy, AfterViewInit {
/**
* open edit modal for a sent message.
*/
async openEditMessagePopup(index: number) {
async openEditMessagePopup(messageOrIndex: Message | number) {
const index =
typeof messageOrIndex === 'number'
? messageOrIndex
: this.messageList.findIndex((message) => message.uuid === messageOrIndex.uuid);
if (index < 0) {
return;
}
const modal = await this.modalController.create({
component: EditMessagePopupComponent,
cssClass: 'chat-edit-message-popup',
Expand Down
Loading