fix(local): satisfy strictTemplates for keyboard and chat handlers#2697
Open
Sunilsbcloud wants to merge 1 commit into
Open
fix(local): satisfy strictTemplates for keyboard and chat handlers#2697Sunilsbcloud wants to merge 1 commit into
Sunilsbcloud wants to merge 1 commit into
Conversation
Widen keyboard event parameters to Event with runtime narrowing and allow openEditMessagePopup to accept a Message or index so v3 builds cleanly under Angular strict template checking in the local Docker dev server. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strictTemplatescompile errors blockingng servein the local Docker stack.Eventwithinstanceof KeyboardEventnarrowing in keyboard-accessible handlers (review-list,badges-certificates,chat-roompreview).switchStatusevent optional inreview-listto match the template binding.openEditMessagePopupto accept aMessageobject (template) or numeric index (existing tests), resolving theMessagevsnumbertype error.Test plan
npx ng build v3 -c developmentdocker compose/ TUI:practera-appcontainer reaches watch mode on port 4200Made with Cursor