Repository navigation
CI: report lint errors before the browser tests and run browser specs on four workers - #3566
Merged
Merged
Conversation
… four workers Validate Changes spent about 56 of its 60 minutes in the browser smoke test: 889 Playwright tests on one worker, with lint and typecheck only afterwards. - Run Checks now comes first and a failed gate skips the browser run. - The browser specs run one file per worker: four workers on hosted runners, two on rootless workers; local runs keep one worker. - creation-short-window.pw.ts, 18% of the suite's test time, spreads its independent tests over the workers. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
|
CI failed: Validate Changes Please investigate and fix this CI failure.
Failure evidence
|
Checks FailedValidation failed during setup, tests, CLI packaging, linting, or build checks. View Logs |
Contributor
|
CI failed: Full Test Suite Shard 2/4 Please investigate and fix this CI failure.
Failure evidence
|
Contributor
|
CI failed: Full Test Suite Shard 4/4 Please investigate and fix this CI failure.
Failure evidence
|
Contributor
|
CI failed: Run Full Test Suite Please investigate and fix this CI failure.
Failure evidence
|
Full Test Suite ResultsValidation failed during: Test shard (shard 2), Test shard (shard 4).
View shard 2/4 outputView shard 4/4 outputDetails truncated; see the uploaded artifacts for complete failure rows and logs. |
Full Test Suite ResultsValidation failed during: Test shard (shard 2), Test shard (shard 4).
View shard 2/4 outputView shard 4/4 outputDetails truncated; see the uploaded artifacts for complete failure rows and logs. |
This was referenced Nov 14, 2026
Owner
Author
|
/merge |
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Validate Changestakes about an hour on a UI-touching PR. The browser smoke test runs 889 Playwright tests on one worker (about 56 minutes), and lint runs only after it, so a lint warning is reported an hour after the push.What changes
Run Checksnow runs before the two browser steps, so a lint or typecheck error is reported within a few minutes. WhenRun Checksfails, the two browser steps are skipped and the job fails without spending the browser time; the browser tests run on the next push once checks pass.PROPR_BROWSER_TEST_WORKERSto 4 on GitHub-hosted runners and 2 on self-hosted ones, andpropr-ui/playwright.config.tsreads it (default 1, so local runs are unchanged).fullyParallelstays off: files run in parallel, tests inside a file stay in order.creation-short-window.pw.tsis the one long spec whose tests are independent, so it opts into parallel mode within the file.test/ciWorkflowDeduplication.test.mjsasserts the new step order and the worker setting.docs/ci-runners.mdandCHANGELOG.mddescribe the change.Verification
node --test test/ciWorkflowDeduplication.test.mjs: 11 of 11 pass.actionlintonpr-build-check.yml: clean.This PR's own
Validate Changesrun is the real measurement on a hosted runner.🤖 Generated with Claude Code