Repository navigation
CI: pin hosted Linux jobs to Ubuntu 24.04 - #3568
Merged
Merged
Conversation
GitHub moved ubuntu-latest to Ubuntu 26.04. rpmbuild there fails the desktop RPM build (%install cannot find the staged usr/ directory), so rpm-maker.test.ts and rpm-signing.test.mjs fail in every full test suite run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub has started serving
ubuntu-latestjobs on the Ubuntu 26.04 image. On that image the full test suite fails on every run:apps/desktop/src/rpm-maker.test.ts:rpmbuildfails in%installwithcp: cannot stat 'usr/*': No such file or directory(theelectron-installer-redhatspec no longer runs in the staged directory under the newerrpmbuild).apps/desktop/scripts/rpm-signing.test.mjs: three subtests fail, ending inRPM must have verified header and package signatures from the pinned identity.Seen on three of three 26.04 runs across #3566 and #3567 today; the same tests passed on 24.04 an hour earlier. One 26.04 run also failed
scripts/ci-install-chromium.shon missing font packages, and passed on the retry.What changes
Every
ubuntu-latestin.github/workflowsbecomesubuntu-24.04(39 places in 11 files), and the runner contract tests that name the label follow.docs/ci-runners.mdrecords why, and that moving to a newer image belongs with the RPM packaging fix.Jobs routed to the self-hosted rootless pool are unaffected.
Verification
test/ciRunnerRouting.test.mjs(51),test/ciFullSuiteSelection.test.mjs(78),test/ciHostedCapacity.test.mjs(5),test/ciWorkflowDeduplication.test.mjs(11) andapps/desktop/scripts/linux-preview-workflow.test.mjs(17) pass.actionlintreports no errors.Not in this PR
Making the desktop RPM build work on Ubuntu 26.04.
🤖 Generated with Claude Code