Skip to content

test(php): skip the fatal error test where PHP itself exits with 1 on running out of memory #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hightemp merged 2 commits into from
Oct 27, 2026
Merged

test(php): skip the fatal error test where PHP itself exits with 1 on running out of memory #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4349393
test(php): show the output of the script when its exit code is wrong
hightemp Oct 27, 2026
d30135c
test(php): skip the fatal error test where PHP itself exits with 1 on…
hightemp Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions client-php/tests/ProcessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testWarningAndUncaughtException(): void
{
[$exitCode, $output, $events] = $this->runScript('errors.php');

self::assertSame(255, $exitCode);
self::assertSame(255, $exitCode, $output);
self::assertStringContainsString('Order 7 not found', $output, 'PHP still reports the uncaught exception');
self::assertStringContainsString('Undefined index: discount', $output, 'and the warning');
self::assertSame(['request_start', 'message', 'error', 'error', 'request_end'], array_column($events, 'type'));
Expand All @@ -51,16 +51,31 @@ public function testWarningAndUncaughtException(): void

public function testFatalError(): void
{
if (!self::phpRunsShutdownAfterOutOfMemory()) {
self::markTestSkipped('This PHP build exits with code 1 on running out of memory and skips shutdown functions, '
. 'without the library too (seen in setup-php builds of PHP 7.4-8.1 from October 2026)');
}
[$exitCode, $output, $events] = $this->runScript('fatal.php');

self::assertSame(255, $exitCode);
self::assertSame(255, $exitCode, $output);
self::assertStringContainsString('Allowed memory size', $output);
self::assertSame(['request_start', 'error', 'request_end'], array_column($events, 'type'));
self::assertSame('fatal', $events[1]['kind']);
self::assertSame('E_ERROR', $events[1]['error_type']);
self::assertSame(255, $events[2]['exit_code']);
}

/** Whether bare PHP, with no extensions and no library, still runs shutdown functions after running out of memory. */
private static function phpRunsShutdownAfterOutOfMemory(): bool
{
$code = 'register_shutdown_function(function () { echo "shutdown"; }); '
. 'while (true) { $chunks[] = str_repeat("x", 1024 * 1024); }';
$command = sprintf('%s -n -d memory_limit=16M -d display_errors=0 -r %s 2>&1', escapeshellarg(PHP_BINARY), escapeshellarg($code));
exec($command, $output, $exitCode);

return $exitCode === 255 && implode("\n", $output) === 'shutdown';
}

public function testProjectOfLibraryV1WithoutComposer(): void
{
[$exitCode, $output, $events] = $this->runScript('compat.php', [
Expand Down
Loading