Use the runner's OpenSSL for Windows release wheels - #168
Merged
Merged
Conversation
The release job installed OpenSSL with `choco install openssl`, whose installer download from slproweb.com fails on GitHub-hosted runners, so the Windows wheels for v1.3.0rc3 never built. The windows-2022 image already installs the full OpenSSL 3.x (headers and import libraries) at C:\Program Files\OpenSSL, so point OPENSSL_ROOT_DIR and delvewheel's --add-path there and log its version before the build. find_package(OpenSSL) is QUIET, so a missing OpenSSL used to produce an HTTP-only wheel without complaint. CMAKE_REQUIRE_FIND_PACKAGE_OpenSSL makes it a configure error for the Windows release build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows wheel build for v1.3.0rc3 failed while installing OpenSSL:
choco install openssldownloads its installer from slproweb.com, and that download is cut off on GitHub-hosted runners, so retries fail too.C:\Program Files\OpenSSL(the full installer, with headers and import libraries).OPENSSL_ROOT_DIRand delvewheel's--add-pathpoint there, and the pre-build step logs its version, failing if it is missing.-DCMAKE_REQUIRE_FIND_PACKAGE_OpenSSL=ONto the Windows CMake arguments.find_package(OpenSSL)isQUIET, so without it a missing OpenSSL builds an HTTP-only wheel without an error.Checked locally with a CMake project using the same lookup: with the flag, a missing OpenSSL fails the configure; without it, the configure passes with
OpenSSL_FOUND=FALSE. Aworkflow_dispatchrun ofrelease.ymlon this branch builds the wheels without publishing.After this merges,
v1.3.0rc3gets re-created on the merge commit. Nothing was published under the current tag.🤖 Generated with Claude Code