Skip to content

Remove an unused variable #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nico wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −1
Open

Remove an unused variable #4100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/test/phonenumbers/phonenumbermatcher_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,6 @@ class PhoneNumberMatcherTest : public testing::Test {
void EnsureTermination(const string& text, const string& default_country,
PhoneNumberMatcher::Leniency leniency) {
for (size_t index = 0; index <= text.length(); ++index) {
string sub = text.substr(index);

@nico nico Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, not quite sure what this test tries to achieve. This line is the only use of index, so not sure what the point is of running this test text.length() times. Maybe the code below wanted to use sub somewhere? Do you know what this attempts to achieve?

As-is, this PR fixes the warning and keeps current behavior.

// Iterates over all matches.
PhoneNumberMatcher matcher(phone_util_, text, default_country, leniency,
1000000 /* max_tries */);
Expand Down
Loading