Repository navigation
Conversation
Contributor
Author
New libc++ has a mode that warns on this, and this is part of enabling that mode in Chromium builds. No behavior change. Part of https://crbug.com/581374525
nico
commented
Nov 5, 2026
| void EnsureTermination(const string& text, const string& default_country, | ||
| PhoneNumberMatcher::Leniency leniency) { | ||
| for (size_t index = 0; index <= text.length(); ++index) { | ||
| string sub = text.substr(index); |
Contributor
Author
There was a problem hiding this comment.
Actually, not quite sure what this test tries to achieve. This line is the only use of index, so not sure what the point is of running this test text.length() times. Maybe the code below wanted to use sub somewhere? Do you know what this attempts to achieve?
As-is, this PR fixes the warning and keeps current behavior.
battre
approved these changes
Nov 6, 2026
battre
left a comment
battre
left a comment
Member
There was a problem hiding this comment.
LGTM
I am not sure how the google-internal library and this are kept in sync. The internal library does not have this line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New libc++ has a mode that warns on this, and this is part of enabling that mode in Chromium builds.
No behavior change.
Part of https://crbug.com/581374525