Use linear scan for flexcomp unused-point reindexing - #3423
Open
teerthsharma wants to merge 1 commit into
Open
Conversation
teerthsharma
marked this pull request as ready for review
July 23, 2026 11:05
teerthsharma
marked this pull request as draft
July 23, 2026 11:44
teerthsharma
marked this pull request as ready for review
July 23, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3422.
Performance
The old loop performs
Theta(P * U)updates forPinput points andUunused points, which is
Theta(P^2)in the worst case. The replacement is oneTheta(P)scan with constant additional state.For a direct tetrahedral flexcomp with four referenced vertices and increasing
unused input points, median compile time at 32,000 points fell from 51.218 ms to
7.201 ms (7.11x faster, 85.9% less wall time). An all-points-used control found
no material regression. The temporary benchmark used to establish this result
is not included in the patch.
Validation
detection: all 60
UserFlexTestcases passed1,926/1,926 tests (one declared locale-dependent test skipped)