Preserve inertial semantics when decoding USD - #3400
Open
LouRohanNV wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves MuJoCo inertial semantics during USD decode:
UsdPhysicsMassAPIauthors both mass and diagonal inertia on a body, mark the decoded body inertial as explicit.UsdPhysicsMassAPImass/density on visualUsdGeomGprimgeoms as well as colliders.MjcImageableAPIgeoms with no authored mass or density asdensity=0, so they do not inherit MuJoCo default density and alter inferred body inertias.Fixes #3399
Why
MuJoCo roundtrip validation showed that visual-only meshes could accidentally gain mass during USD import, and explicit inertials could be lost during compilation. Both affect sampled dynamics.
USD / non-USD impact
The change is contained to
plugin/usd_decoder, which is only built whenMUJOCO_WITH_USD=ON.Validation
Roundtrip evidence:
MjcImageableAPIgeoms todensity=0.