Skip to content

docs: fix CompilerExtension default impl in ir.md and missing container_runtime.rs in AGENTS.md tree #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

docs: fix CompilerExtension default impl in ir.md and missing container_runtime.rs in AGENTS.md tree #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ fail-closed and only pauses when the agent actually proposed a reviewed output.
│ │ │ ├── github.rs # Always-on GitHub MCP extension
│ │ │ ├── safe_outputs.rs # Always-on SafeOutputs MCP extension
│ │ │ ├── ado_script.rs # Always-on ado-script extension (gate evaluator + runtime-import resolver + execution-context precomputes, per-job downloads)
│ │ │ ├── container_runtime.rs # Typed Docker runtime configuration for MCPG stdio servers (mount modes, container args)
│ │ │ ├── exec_context/ # Always-on execution-context extension (issue #860)
│ │ │ │ ├── mod.rs # ExecContextExtension; CompilerExtension impl; contributor fan-out
│ │ │ │ ├── contributor.rs # Internal ContextContributor trait + Contributor enum
Expand Down
6 changes: 5 additions & 1 deletion docs/ir.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,11 @@ The extension trait lives in `src/compile/extensions/mod.rs` and now has exactly
pub trait CompilerExtension {
fn name(&self) -> &str;
fn phase(&self) -> ExtensionPhase;
fn declarations(&self, ctx: &CompileContext) -> Result<Declarations>;
/// Default returns `Ok(Declarations::default())` — override when the
/// extension contributes steps, hosts, tools, or other signals.
fn declarations(&self, ctx: &CompileContext) -> Result<Declarations> {
Ok(Declarations::default())
}
}
```

Expand Down