docs: fix CompilerExtension default impl in ir.md and missing container_runtime.rs in AGENTS.md tree - #2115
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…e.rs entry - docs/ir.md showed CompilerExtension::declarations() as a required method with no body, contradicting docs/extending.md and the actual trait in src/compile/extensions/mod.rs, which gives it a default implementation returning Ok(Declarations::default()). - AGENTS.md's architecture tree omitted src/compile/extensions/container_runtime.rs, an existing module (typed Docker runtime config for MCPG stdio servers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Documentation Update
Findings
docs/ir.md'sCompilerExtensiontrait snippet showeddeclarations()as a required method with no body, contradictingdocs/extending.mdand the actual trait definition insrc/compile/extensions/mod.rs, which gives it a default implementation (Ok(Declarations::default())). A reader ofir.mdalone would incorrectly conclude every extension must implementdeclarations().docs/ir.md,src/compile/extensions/mod.rsAGENTS.md's architecture tree undersrc/compile/extensions/omittedcontainer_runtime.rs, an existing module providing typed Docker runtime configuration for MCPG stdio servers (mount modes, container args).AGENTS.md,src/compile/extensions/container_runtime.rsApplied Fixes
CompilerExtensiontrait code block indocs/ir.mdto include the defaultdeclarations()implementation, matchingdocs/extending.mdand the real trait.container_runtime.rsentry to theextensions/subtree inAGENTS.md's architecture diagram.Notes
Verified by reading
src/compile/extensions/mod.rsdirectly (trait definition at theCompilerExtensiondeclaration) and confirmingdocs/extending.mdalready documented the default correctly, makingdocs/ir.mdthe outlier. Confirmedcontainer_runtime.rsexists on disk and is referenced bymod.rsbut was absent from the AGENTS.md tree via a full diff offind src -name '*.rs'against filenames mentioned in AGENTS.md. Other areas audited this run (CLI commands, safe-outputs tool table, front-matter fields, network/ir/extending cross-checks, schedule-syntax, tools/runtimes config, parameters/execution-context/conclusion, all threeprompts/*.mdguides) showed no material drift, so no changes were made there.Created by the agent-documentation maintainer workflow.