Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severity: medium (BZ-16-1) - bumping to 0.20.0 breaks the required
Unit testscheck (6 failures intests/native.test.ts,native-version-mismatchfromsrc/native.ts:258). The real-CLI fixture intests/native.test.ts(~line 218) hardcodesversion: '0.19.0'while the installed CLI now reports 0.20.0.Suggested fix: update that fixture version to 0.20.0 (ideally derive it from the installed
@microsoft/vally-cli/package.json), and keep the other pins consistent:.github/workflows/ci.ymlvally-version: 0.19.0(3 places), README lines 96/411, andtests/tooling.test.ts:111if intended to track the dev dependency.tests/tooling.test.ts:44also treats 0.20.0 as a mismatched metadata version; confirm that stays valid.