Repository navigation
Bump @microsoft/vally-cli from 0.19.0 to 0.20.0 - #16
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps @microsoft/vally-cli from 0.19.0 to 0.20.0. --- updated-dependencies: - dependency-name: "@microsoft/vally-cli" dependency-version: 0.20.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
There was a problem hiding this comment.
Verdict: changes requested.
This update only bumps the test tool Vally from 0.19.0 to 0.20.0. One automated check, Unit tests, fails on this change. The test setup in tests/native.test.ts still declares version 0.19.0, but the installed tool now reports 0.20.0, so the code in src/native.ts stops with a version-mismatch error. Six tests fail.
Required fix: update the declared version in that test setup, and keep the other 0.19.0 pins (CI workflow, README) consistent. Details are in the inline comment.
Limits: nothing was installed or run locally; the failure comes from the CI log. The lockfile changes look consistent with the bump.
Generated by 🌳Breza Bot
| }, | ||
| "devDependencies": { | ||
| "@microsoft/vally-cli": "0.19.0", | ||
| "@microsoft/vally-cli": "0.20.0", |
There was a problem hiding this comment.
Severity: medium (BZ-16-1) - bumping to 0.20.0 breaks the required Unit tests check (6 failures in tests/native.test.ts, native-version-mismatch from src/native.ts:258). The real-CLI fixture in tests/native.test.ts (~line 218) hardcodes version: '0.19.0' while the installed CLI now reports 0.20.0.
Suggested fix: update that fixture version to 0.20.0 (ideally derive it from the installed @microsoft/vally-cli/package.json), and keep the other pins consistent: .github/workflows/ci.yml vally-version: 0.19.0 (3 places), README lines 96/411, and tests/tooling.test.ts:111 if intended to track the dev dependency. tests/tooling.test.ts:44 also treats 0.20.0 as a mismatched metadata version; confirm that stays valid.
Generated by 🌳Breza Bot
|
Superseded by #29. |
Bumps @microsoft/vally-cli from 0.19.0 to 0.20.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)