refactor(control-plane): decouple pool tests from EC2 - #5307
Open
edersonbrilhante wants to merge 1 commit into
Open
refactor(control-plane): decouple pool tests from EC2#5307edersonbrilhante wants to merge 1 commit into
edersonbrilhante wants to merge 1 commit into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #5306.
Refactors the control-plane pool tests to use the
PoolComputeProvidercapability boundary instead of importing and mocking the EC2 runner implementation.EC2-specific assertions for running-instance filters, busy and booting runner counts, and the
pool-lambdasource now live in the EC2 pool provider tests. Generic pool orchestration coverage remains in the control-plane test.Test Plan
git diff --checkagainstrefactor-ec2-runner-operations.Related Issues
None.