refactor(control-plane): remove EC2 assumptions - #5308
Open
edersonbrilhante wants to merge 1 commit into
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #5307.
Removes EC2-specific assumptions from generic control-plane tests and the local pool invocation. Scale-up and scale-down test doubles now model provider capability factories without owning a provider type, partial creation tests use provider-neutral runner terminology, and pool events rely on the optional provider type's default behavior.
The scale-up provider-selection test remains as integration coverage, but asserts the public
defaultComputeProvidercontract instead of the concrete EC2 value. The provider-type unit tests remain responsible for the concrete default mapping.Test Plan
git diff --check.Related Issues
None.