Skip to content

Fix Settings updates interrupted by plugin reloads - #111

Merged
gitcoder89431 merged 1 commit into
masterfrom
fix/settings-update-worker
Oct 15, 2026
Merged

gitcoder89431 merged 1 commit into
masterfrom
fix/settings-update-worker

Conversation

@gitcoder89431

Copy link
Copy Markdown
Owner

Settings' Update button could pull and deploy new files, then lose its updater when deployment reloaded the Settings plugin. The update stopped before the final shell restart, leaving stale UI and an interrupted lifecycle journal; users had to run omarchy restart shell manually.

Run the entire GUI update in a separate session with independent stdio, while retaining a relay for errors while Settings is alive. Save the latest output to ~/.local/state/ruixen/settings-update.log and reject concurrent GUI updates without truncating the active log. Continue using the existing updater and lifecycle lock. Document the behavior and lifecycle rule.

Validation:

  • Added a regression test that kills the launching process group before completion and verifies the worker survives, plus concurrency and failure propagation checks.
  • ./tests/run-all.sh passed.
  • ./install.sh --dry-run and omarchy plugin validate ruixen.launcher passed.
  • Installed locally, confirmed a full shell restart with a new PID, verified IPC response and About page loading, and checked startup logs for missing QML types or plugin fallback.

@gitcoder89431
gitcoder89431 merged commit 695d60c into master Oct 15, 2026
1 check passed
@gitcoder89431
gitcoder89431 deleted the fix/settings-update-worker branch October 15, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant