Repository navigation
Fix Settings updates interrupted by plugin reloads - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings' Update button could pull and deploy new files, then lose its updater when deployment reloaded the Settings plugin. The update stopped before the final shell restart, leaving stale UI and an interrupted lifecycle journal; users had to run
omarchy restart shellmanually.Run the entire GUI update in a separate session with independent stdio, while retaining a relay for errors while Settings is alive. Save the latest output to
~/.local/state/ruixen/settings-update.logand reject concurrent GUI updates without truncating the active log. Continue using the existing updater and lifecycle lock. Document the behavior and lifecycle rule.Validation:
./tests/run-all.shpassed../install.sh --dry-runandomarchy plugin validate ruixen.launcherpassed.