Repository navigation
Fix compact notch title spinner alignment - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex's braille spinner appeared above the adjacent window-title text in the compact notch on a MacBook at 1.6× display scale. The notch rendered the spinner and title on one baseline even though the spinner uses the upper three rows of an eight-dot braille cell.
Render recognized leading spinner frames separately and align the measured six-dot grid with the font's capital-letter bounds. Measure the full grid for every frame so sparse frames rotate without vertical jitter. Keep the title centered and elided, with ordinary titles rendered intact as plain text.
Validation:
qmllint bars/widgets/ruixen.notch/CompactWindowTitle.qml,./tests/notch-media-viz-mode.sh,./install.sh --dry-run, andomarchy plugin validate "$HOME/.config/omarchy/plugins/ruixen.notch"passed../tests/run-all.shpassed.This PR is independent of #111.