Skip to content

test(e2e): Skip the redirect in the react-router-7 double-instrumentation check #23958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Sep 2, 2026
Merged

test(e2e): Skip the redirect in the react-router-7 double-instrumentation check #23958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309a9e4
test(e2e): Report which segment duplicates in the react-router-7 check
Lms24 Sep 2, 2026
5553242
test(e2e): Skip the redirect in the react-router-7 double-instrumenta…
Lms24 Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions ...ons/react-router-7-framework-instrumentation/tests/performance/performance.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,21 +135,40 @@ test.describe('server - instrumentation API performance', () => {
'Dev server emits extra http.server segments for module requests',
);

const httpServerSpanNames: string[] = [];
// Navigate to `/performance/` with the trailing slash: `/performance` is answered with a 301 to
// it, and that redirect is a second request with a second `http.server` segment. It should not
// be sent at all — `ignoreStatusCodes` covers 301 — but that option is only applied to
// transactions, so span streaming emits it. Going straight to the final URL keeps this test
// about double-instrumentation instead of failing on the redirect.
//
// A streamed server segment is named after the method alone until a route is matched, so a
// duplicate shows up as a bare `GET`. Collect the origin and path alongside the name — they are
// what says which instrumentation emitted the extra segment, and for which request.
const httpServerSegments: Array<Record<string, unknown>> = [];
void waitForStreamedSpans(APP_NAME, spans => {
for (const span of spans) {
if (getSpanOp(span) === 'http.server' && span.is_segment) {
httpServerSpanNames.push(span.name);
httpServerSegments.push({
name: span.name,
origin: span.attributes['sentry.origin']?.value,
urlPath: span.attributes['url.path']?.value,
});
}
}
return false;
});

await page.goto(`/performance`);
await page.goto(`/performance/`);
// Give any (erroneous) duplicate span time to arrive before asserting.
await page.waitForTimeout(3000);

expect(httpServerSpanNames).toEqual(['GET /performance']);
expect(httpServerSegments).toEqual([
{
name: 'GET /performance',
origin: 'auto.http.react_router.instrumentation_api',
urlPath: '/performance/',
},
]);
});

test('resolves a real http.route on routes without a loader/action', async ({ page }) => {
Expand Down
Loading