test(e2e): Skip the redirect in the react-router-7 double-instrumentation check - #23958
Merged
Lms24 merged 2 commits intoSep 2, 2026
Merged
Conversation
The double-instrumentation check has failed on develop since #23844 ported this app to span streaming, and its failure output says only that a bare `GET` segment showed up — not which instrumentation emitted it or which request it belongs to, which is exactly what is needed to tell a genuine duplicate apart from an unrouted second request. Collect `sentry.origin` and `url.path` alongside the name so the received value names the culprit, and assert the surviving segment comes from the instrumentation API rather than only checking its name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…tion check `/performance` is answered with a 301 to `/performance/`, so the navigation makes two requests and the redirect gets its own `http.server` segment. That segment should never be sent — `ignoreStatusCodes` covers 301 by default — but the option is applied in a `processEvent` hook that returns early for anything that is not a transaction, so span streaming emits it. The check has failed on develop since #23844 put this app on span streaming. Navigate straight to the final URL so the test stays about what it is named after. The underlying `ignoreStatusCodes` gap affects Node and Deno alike and is tracked separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
chargome
approved these changes
Sep 2, 2026
Lms24
deleted the
lms/fix-rr7-instrumentation-double-http-server-span
branch
September 2, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a "workaround" to fix an e2e test fail triggered by switching it to span streaming: For our React router 7 e2e tests,
/performanceredirects with status 301 to/performance/, sopage.goto('/performance')makes two requests and the redirect gets its ownhttp.serversegment.In static trace lifecycle, the 301 segment should never be sent:
ignoreStatusCodesdrops 301 by default. But in span streaming, we can no longer ignore spans based on response status codes.To fix the test, it now goes straight to
/performance/, so there is no redirect and it stays about what it is named after.#23956 tracks deprecating the related
ignoreStatusCodesoption