feat(core): Emit low cardinality router span names - #23547
Open
logaretm wants to merge 1 commit into
Open
Conversation
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/js-3417-emit-low-cardinality-router-span-names
branch
2 times, most recently
from
August 24, 2026 18:38
5d83782 to
1318630
Compare
Names `router` spans after the route they dispatch when span streaming is enabled, falling back to `Router` when the SDK has no route, per https://getsentry.github.io/sentry-conventions/names/#routing-router. Covers all seven sites that emit the `router` op: the OTel-derived and orchestrion Express integrations, Koa, Hapi, Angular, Ember and SvelteKit (Svelte 4 and 5). Two of them were leaking high-cardinality values: the orchestrion Express integration named router spans `layer.path`, which Express assigns the *matched* URL segment (verified against express 4.22.1: `app.use('/users/:id', router)` yields `/users/123`), and Angular named them the raw navigation URL, since the parameterized route only resolves at `ResolveEnd` and is applied to the root span rather than to the routing span. Angular, Ember and SvelteKit have no route value at the span, so they take the fallback. Hapi drops its `GET ` prefix because the convention's template has no method component. `traceLifecycle: 'static'` names are byte-identical; the existing static integration and e2e assertions are the regression check.
logaretm
force-pushed
the
awad/js-3417-emit-low-cardinality-router-span-names
branch
from
August 24, 2026 18:44
1318630 to
be3a06a
Compare
logaretm
marked this pull request as ready for review
August 24, 2026 18:50
logaretm
requested review from
chargome and
nicohrubec
and removed request for
a team
August 24, 2026 18:50
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be3a06a. Configure here.
|
|
||
| const client = getClient(); | ||
| // With span streaming, span names have to be low cardinality, so router spans are named after their route. | ||
| const isStreamedRouterSpan = layerType === LAYER_TYPE.ROUTER && !!client && hasSpanStreamingEnabled(client); |
There was a problem hiding this comment.
Avoidable getClient calls
Low Severity
Flagged because it was mentioned in the review rules file — this is more an "is this necessary" check than a hard violation. These sites newly call getClient() to gate span streaming, while the Koa, Express, and Hapi integrations already receive a client in setup. Prefering that existing reference would avoid relying on ambient current-client state in multi-client setups.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit be3a06a. Configure here.
| description: 'Router', | ||
| }, | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E tests
Low Severity
Flagged because it was mentioned in the review rules file. This is a feat PR, and the new coverage is package-level unit tests (Express patch-layer, Hapi utils, SvelteKit). The guidelines ask for at least one integration or E2E test so the streamed router naming is exercised against a real framework request or navigation path.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit be3a06a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names
routerspans after the route they dispatch when span streaming is enabled, elseRouter. Static mode is unchanged./cmount pathhttp.route/users/123http.route/users/:idRouterif pathlessGET /users/{id}/users/{id}/users/123Routerroute:a -> route:bRouterSvelteKit Route ChangeRouterOnly Koa already used its
http.route. Hapi drops the method since the template has none; Angular, Ember and SvelteKit carry no route.closes #23532