test(angular, ember): Cover router span name fallbacks - #23548
Open
logaretm wants to merge 1 commit into
Open
Conversation
logaretm
force-pushed
the
awad/js-3417-router-span-name-tests
branch
2 times, most recently
from
August 24, 2026 18:38
3e2995c to
5ae2b30
Compare
logaretm
force-pushed
the
awad/js-3417-router-span-name-tests
branch
from
August 24, 2026 18:44
5ae2b30 to
623edef
Compare
Covers the router span name fallback end to end, not just at the unit level. Both apps get a `sentryTest.variants` entry, which the e2e matrix expands into a second matrix row that rebuilds the app with `traceLifecycle: 'stream'` and runs the suite again. Ember is built by Vite, so the lifecycle is a plain env var (`VITE_TRACE_LIFECYCLE`). Angular can't read `process.env` in the browser bundle, so it uses the builder's `fileReplacements` to swap `trace-lifecycle.ts` for `trace-lifecycle.streamed.ts` under a new `streamed` build configuration. The assert command sets `E2E_TEST_TRACE_LIFECYCLE`, which the specs read: the streamed specs skip unless it is set, and the transaction-based specs skip when it is, since span streaming emits spans rather than transactions.
logaretm
force-pushed
the
awad/js-3417-router-span-name-tests
branch
from
August 24, 2026 18:44
623edef to
549f0db
Compare
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
August 24, 2026 19:37
logaretm
requested review from
a team,
chargome and
nicohrubec
and removed request for
a team
August 24, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the router span name fallback #23547 added, for the two SDKs it left untested.