feat(server-utils)!: Align AMQP and Redis span attributes - #23324
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Develop landed overlapping semantic-convention work (#23408, #23422, #23353, #23405) and restructured the redis integration into `integrations/redis/`. Conflicts were resolved by keeping develop's file layout and layering this branch's attribute changes on top: - ioredis/node-redis spans emit `db.operation.name` and drop `db.connection_string`; `server.address`/`server.port` are only set when known. - The ioredis orchestrion span op moves from `db` to `db.query`, and the connect span to `db` via `SENTRY_OP`, matching the native diagnostics-channel subscriber develop added. - AMQP keeps this branch's removal of the legacy `messaging.*` attributes and adds `messaging.operation.name`. - Test conditionals on the deleted `isOrchestrionEnabled()` helper (#23435) collapse to their channel branch. - `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis coverage now lives in `nextjs-16/tests/db-page.test.ts`. The v11 migration doc keeps develop's subsection structure with this branch's AMQP and Redis specifics folded in.
s1gr1d
marked this pull request as ready for review
August 24, 2026 13:23
s1gr1d
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 24, 2026 13:23
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4d6db2e. Configure here.
s1gr1d
enabled auto-merge (squash)
August 25, 2026 11:31
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 27, 2026
Adds the legacy AMQP `messaging.*` attributes and `db.connection_string` that the JavaScript SDK stopped emitting in v11, so that the old names keep pointing at their replacements while dashboards and alerts migrate. `db.connection_string` has no single replacement: the connection is now described by `server.address` and `server.port`, so it carries a reason instead of a `replacement` and gets no alias. Deprecated by getsentry/sentry-javascript#23324 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 28, 2026
Adds the legacy AMQP `messaging.*` attributes and `db.connection_string` that the JavaScript SDK stopped emitting in v11, so that the old names keep pointing at their replacements while dashboards and alerts migrate. `db.connection_string` has no single replacement: the connection is now described by `server.address` and `server.port`, so it carries a reason instead of a `replacement` and gets no alias. Deprecated by getsentry/sentry-javascript#23324 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 28, 2026
Adds the legacy AMQP `messaging.*` attributes and `db.connection_string` that the JavaScript SDK stopped emitting in v11, so that the old names keep pointing at their replacements while dashboards and alerts migrate. `db.connection_string` has no single replacement: the connection is now described by `server.address` and `server.port`, so it carries a reason instead of a `replacement` and gets no alias. Deprecated by getsentry/sentry-javascript#23324 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
added a commit
to getsentry/sentry-conventions
that referenced
this pull request
Aug 28, 2026
…ed) (#581) * feat(attributes): Add legacy AMQP and Redis span attributes (deprecated) Adds the legacy AMQP `messaging.*` attributes and `db.connection_string` that the JavaScript SDK stopped emitting in v11, so that the old names keep pointing at their replacements while dashboards and alerts migrate. `db.connection_string` has no single replacement: the connection is now described by `server.address` and `server.port`, so it carries a reason instead of a `replacement` and gets no alias. Deprecated by getsentry/sentry-javascript#23324 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * Update model/attributes/db/db__connection_string.json Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> * fixup! Update model/attributes/db/db__connection_string.json --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align AMQP, Redis, and ioredis tracing-channel spans with the current Sentry semantic conventions.
Closes #22363