feat(attributes): Add legacy AMQP and Redis span attributes (deprecated) - #581
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Names
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
JPeer264
force-pushed
the
jp/conv-amqp-redis-legacy-attrs
branch
from
August 27, 2026 08:11
533dfee to
f60ca02
Compare
JPeer264
marked this pull request as ready for review
August 27, 2026 08:14
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 27, 2026 08:14
Lms24
approved these changes
Aug 27, 2026
Comment on lines
+10
to
+12
| "deprecation": { | ||
| "_status": null, | ||
| "reason": "This attribute is deprecated. The connection is described by server.address and server.port instead, so the value cannot be copied to a single replacement attribute." |
Member
There was a problem hiding this comment.
good call to not add a replacement here, since it's two attributes that make up for this one. Thanks!
JPeer264
force-pushed
the
jp/conv-amqp-redis-legacy-attrs
branch
2 times, most recently
from
August 28, 2026 11:49
a4486da to
b463e2c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Adds the legacy AMQP `messaging.*` attributes and `db.connection_string` that the JavaScript SDK stopped emitting in v11, so that the old names keep pointing at their replacements while dashboards and alerts migrate. `db.connection_string` has no single replacement: the connection is now described by `server.address` and `server.port`, so it carries a reason instead of a `replacement` and gets no alias. Deprecated by getsentry/sentry-javascript#23324 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
JPeer264
force-pushed
the
jp/conv-amqp-redis-legacy-attrs
branch
from
August 28, 2026 12:12
02abe22 to
a61edde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the seven legacy AMQP
messaging.*attributes anddb.connection_string, which the JavaScript SDK stopped emitting in v11. Without a definition here, nothing tells a user what replaced them.db.connection_stringhas no single replacement: the connection is now described byserver.addressandserver.port. It therefore carries a reason instead of areplacement, and gets no alias, so that no two-target alias group is created. (is there any protocol on how to treat these?)messaging.protocol,messaging.protocol_versionandmessaging.urljoin existing alias groups, so the other members of those groups gain the new key as well.Deprecated by getsentry/sentry-javascript#23324