Repository navigation
fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed - #6626
Merged
Merged
Conversation
markushi
requested review from
0xadam-brown and
runningcode
and removed request for
a team
November 16, 2026 19:22
📲 Install BuildsAndroid
|
runningcode
reviewed
Nov 17, 2026
runningcode
reviewed
Nov 17, 2026
…e unit test tasks
3 tasks done
3 tasks done
4 of 9 tasks
8 of 9 tasks
adinauer
added a commit
that referenced
this pull request
Nov 20, 2026
* collection: Servlet API compatibility * chore(deps): bump javax.servlet:javax.servlet-api from 3.1.0 to 4.0.1 (#6475) Bumps [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1. - [Commits](javaee/servlet-spec@3.1.0...4.0.1) --- updated-dependencies: - dependency-name: javax.servlet:javax.servlet-api dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(servlet): Keep Servlet 3.1 as compatibility floor Compile the javax servlet integrations against the minimum supported API. Exclude the intentionally pinned API from Dependabot while retaining the separate Servlet 4 alias for latest-runtime coverage. Co-Authored-By: Claude <noreply@anthropic.com> * test(servlet): Test Servlet 3.1 and 4.0 runtimes (#6625) * test(servlet): Test Servlet 3.1 on Tomcat 8.5 Run sentry-servlet against the minimum supported servlet container while keeping Servlet 3.1 as the production compile target. Exercise the service-loaded initializer through a real HTTP request and verify that request context reaches Sentry. * test(servlet): Run integration test on Tomcat 9 Reuse the real-container servlet integration test with a Tomcat 9 and Servlet 4 runtime classpath. Keep the Tomcat 8.5 run as the minimum-runtime check and attach both runs to the verification lifecycle. * build(servlet): Use JVM test suites for Tomcat matrix Replace the hand-built Tomcat 9 test task with isolated JVM test suites. Run the shared servlet integration test with independent Tomcat 8.5 and Tomcat 9 dependency graphs and attach both suites to check. Co-Authored-By: Claude <noreply@anthropic.com> * build(servlet): Remove unused Truth dependency The servlet integration suites declare Truth directly, so the regular unit test configuration no longer needs it after moving the integration test. Co-Authored-By: Claude <noreply@anthropic.com> * build(deps): Share the Tomcat 9 version Reference one catalog version from the Tomcat 9 core, Catalina, and Jasper aliases so dependency updates keep the runtime components aligned. Co-Authored-By: Claude <noreply@anthropic.com> * test(servlet): Run Tomcat matrix in dedicated CI job Compile the servlet integration test once and execute it with separate Tomcat 8.5 and Tomcat 9 runtime targets. Move both targets out of the standard check lifecycle and run them in a dedicated CI job. Co-Authored-By: Claude <noreply@anthropic.com> * ci: Move integration tests to dedicated workflow Create a shared workflow for non-Spring Boot integration suites and move the servlet runtime matrix there instead of adding it to the main build workflow. Co-Authored-By: Claude <noreply@anthropic.com> * ci: Restrict integration test workflow permissions Limit the workflow token to read-only repository contents because the test, artifact, and step-summary operations do not require write access. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> * build(deps): Share the Tomcat 11 version Restore Tomcat 11.0.27 after the collection branch merge and use one catalog version for Catalina and embedded Jasper so future updates keep them aligned. Co-Authored-By: Claude <noreply@anthropic.com> * Revert "fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed (#6626)" This reverts commit 7eda470. Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io> * Reapply "fix(replay): Support Compose 1.13 and mask Compose views that can't be traversed (#6626)" This reverts commit ee14ece. Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io> * build: Lower Gradle daemon heap to 7g and metaspace to 1g Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io> * build: Restore 8g Gradle heap and cap Kotlin daemon heap at 3g Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Nelson Osacky <nelson.osacky@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
LayoutNodechildren and transparency through the unmangledSemanticsInfoAPI (childrenInfo,isTransparent()), because Compose 1.13 renamed the mangled internals. Compose < 1.8 keeps the reflection fallback.Why
childrenInfoandisTransparent()are drop-in replacementsBoth are public, unmangled
SemanticsInfomembers onLayoutNode(afinalclass). Each one only forwards to the mangled internal that we called before:Only
<suffix>changes between versions. I disassembled all 57androidx.compose.ui:ui-androidreleases from 1.9.0-alpha01 to 1.13.0-rc01:getChildrenInfo()callsisTransparent()callsgetChildren$ui_release()getOuterCoordinator$ui_release()getChildren$ui()getOuterCoordinator$ui()getChildren$androidx_compose_ui_ui()getOuterCoordinator$androidx_compose_ui_ui()The SDK compiles against 1.10.2, so the old direct calls were fixed to
$uiand threwNoSuchMethodErrorfrom 1.13.0-beta01. The reflection fallback only knows the$ui_releasenames.💚 How did you test it?
Unit tests in
ComposeMaskingOptionsTest, and the new Compose matrix workflow.Manual testing: https://sentry-sdks.sentry.io/explore/replays/9a84e9904b76410bb06bddc5cf2ab36a
📝 Checklist
🤖 Generated with Claude Code