Repository navigation
ci(replay): Test Session Replay against Compose UI versions from a checked-in file - #6638
Merged
Merged
Conversation
…s from Google Maven Replace the hardcoded composeUi112/composeUi113 build types with a Compose UI matrix workflow. Like the AGP matrix in sentry-android-gradle-plugin, a Kotlin script reads androidx.compose.ui:ui's maven-metadata.xml and picks the latest stable and, when newer, the latest pre-release. Each matrix job runs the replay unit tests with VERSION_COMPOSE_UI forcing that version on the test runtime classpath. The workflow also runs daily, so new Compose releases are tested without a version bump PR. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
📲 Install BuildsAndroid
|
GitHub only notifies the workflow's creator about scheduled runs, which is the bot that pushed it, so a failing daily run would go unnoticed. On a scheduled failure, open an issue, or comment on the open one so repeated failures stay in one place. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
Like the Spring Boot matrix, keep the Compose UI versions in gradle/compose-ui-versions.json instead of looking them up on Google Maven on every run, so the same commit always tests the same versions. Drop the daily schedule and its failure issue, which only made sense with the live lookup. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
…ency matrix plugin Adds io.sentry.dependency-matrix, which reads a versions file in gradle/ and registers <name>Test<version> tasks. Android modules get a build type per version, kept out of check; JVM modules reuse the compiled tests on a versioned runtime classpath. The workflow reads the file with jq inline, like the Spring Boot matrix workflows. Co-Authored-By: roman <roman.zavarnitsyn@sentry.io> Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
romtsn
marked this pull request as ready for review
November 20, 2026 09:59
romtsn
requested review from
romtsn and
runningcode
and removed request for
a team
November 20, 2026 09:59
Contributor
PR risk: mediumFor commit The model rated this change low. It was raised to medium because:
This label is a hint for reviewers, not an approval. |
runningcode
reviewed
Nov 20, 2026
runningcode
reviewed
Nov 20, 2026
runningcode
reviewed
Nov 20, 2026
runningcode
left a comment
Contributor
There was a problem hiding this comment.
we might also want to put a commetn somewhere that when we can use AGP test suites we should double check this solution
… dependency matrix plugin
Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io> Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This replaces the hardcoded
composeUiTestVersionsbuild types from #6626 (composeUi112,composeUi113) with a Compose UI matrix:gradle/compose-ui-versions.jsonlists the Compose UI versions to test:1.8.3. It pinsmaterial3to1.3.2, because the catalog'smaterial31.4.0 needs a newer Compose UI.io.sentry.dependency-matrix, reads a versions file fromgradle/and registers a<name>Test<version>task for each version, such ascomposeUiTest1_13_0_rc01, and a<name>Testtask that runs them one after another. Each version task runs the module's unit tests with every dependency in the given groups at that version:dependencyMatrix { matrix( name = "composeUi", groups = listOf("androidx.compose.ui", "androidx.compose.foundation", "androidx.compose.animation", "androidx.compose.runtime"), versionsFile = "compose-ui-versions.json", ) }{"version": "1.8.3", "pin": {"androidx.compose.material3": "1.3.2"}}. The object form also forces each group inpinto its own version, for test dependencies whose current version needs a newer one.test/check, so the required Build Job only runs the release unit tests..github/workflows/compose-ui-matrix.ymlruns:sentry-android-replay:composeUiTest --continuein one job on PRs and on pushes tomain, so the workflow doesn't list the versions itself.The same commit always tests the same versions. A new Compose release comes in as a change to the JSON file.
💡 Motivation and Context
Session Replay calls Compose internals whose mangled JVM names change between Compose versions. Adding or removing a version is now a one-line change to the JSON file, and other Android dependencies (e.g. Room) can reuse the plugin.
The replay tests can't go below 1.8: on 1.7 they don't compile, because they mock
LayoutNode.semanticsConfiguration.Trade-off:
checkstill compiles the matrix variants, becauseverifyMethodParametersreads every variant's AAR. That's the same as onmaintoday.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Once this merges, a daily Junior automation bumps the latest stable and pre-release entries in
gradle/compose-ui-versions.jsonwhen Google Maven has a newer Compose UI version, and keeps the oldest-version entry as it is. It force-pusheschore/update-jetpack-compose-ui-testsand asks @getsentry/team-mobile-android-sdk to review. Dependabot can't update a custom JSON file, andgetsentry/github-workflows/updateronly follows git tags, which AndroidX doesn't publish for Compose.#skip-changelog
via roman, no.
--
View Session [Sentry]