Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions devservices/commands/reset.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ def add_parser(subparsers: _SubParsersAction[ArgumentParser]) -> None:
parser.add_argument(
"service_name",
help="Name of the service to reset volumes for",
nargs="?",
default=None,
)
parser.set_defaults(func=reset)

Expand Down
7 changes: 2 additions & 5 deletions devservices/commands/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,9 @@ def update(_args: Namespace) -> None:
if is_in_virtualenv():
console.warning("You are running in a virtual environment.")
console.warning(
"To update, please update your requirements.txt or requirements-dev.txt file with the new version."
f"To update, set the devservices requirement in your pyproject.toml to: devservices>={latest_version}"
)
console.warning(
f"For example, update the line in requirements.txt to: devservices=={latest_version}"
)
console.warning("Then, run: pip install --update -r requirements.txt")
console.warning("Then, run: uv lock --upgrade-package devservices && uv sync")
return

console.info("Upgrading to the latest version...")
Expand Down
12 changes: 12 additions & 0 deletions tests/commands/test_reset.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
from __future__ import annotations

from argparse import ArgumentParser
from argparse import Namespace
from pathlib import Path
from unittest import mock

import pytest

from devservices.commands.reset import add_parser
from devservices.commands.reset import reset
from devservices.constants import DEVSERVICES_ORCHESTRATOR_LABEL
from devservices.exceptions import DockerDaemonNotRunningError
Expand All @@ -15,6 +17,16 @@
from testing.utils import create_config_file


def test_reset_requires_service_name() -> None:
parser = ArgumentParser()
add_parser(parser.add_subparsers())

with pytest.raises(SystemExit):
parser.parse_args(["reset"])

assert parser.parse_args(["reset", "redis"]).service_name == "redis"


@mock.patch(
"devservices.commands.reset.get_matching_containers",
side_effect=DockerDaemonNotRunningError(),
Expand Down
9 changes: 3 additions & 6 deletions tests/commands/test_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,11 @@ def test_update_in_virtualenv(
captured = capsys.readouterr()
assert "You are running in a virtual environment." in captured.out
assert (
"To update, please update your requirements.txt or requirements-dev.txt file with the new version."
"To update, set the devservices requirement in your pyproject.toml to: devservices>=1.0.0"
in captured.out
)
assert (
"For example, update the line in requirements.txt to: devservices==1.0.0"
in captured.out
)
assert "Then, run: pip install --update -r requirements.txt" in captured.out
assert "Then, run: uv lock --upgrade-package devservices && uv sync" in captured.out
assert "pip" not in captured.out


@mock.patch("devservices.commands.update.metadata.version", return_value="0.0.1")
Expand Down
Loading