Repository navigation
fix: Correct the update hint and require a service name for reset - #335
Merged
Merged
Conversation
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
Co-Authored-By: Joshua Li <14209781+joshuarli@users.noreply.github.com>
joshuarli
approved these changes
Oct 17, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are code issues found during the docs refresh in #334.
update: inside a virtualenv, the command told you to runpip install --update -r requirements.txt. pip has no--updateflag, so that command fails. It now says--upgrade.reset:service_namewas optional (nargs="?"), butresethas no current-directory fallback. Runningdevservices resetwith no name filtered containers oncom.docker.compose.service=Noneand exited with "No containers found for None".resettargets a Docker Compose service name, not a devservices service, so the current-directory lookup the other commands use does not fit. The argument is now required, and argparse prints a usage error. A new parser test fails before this change and passes after it.Skipped: I had reported that
pyproject.tomldescribes theintegrationmarker as "run in CI only" without anything skipping those tests locally. That was wrong. The only integration test,test_build_api_request_downloads_real_zip, already hasskipif(not os.environ.get("CI")).via @joshuarli.
--
View Junior Session [Sentry]