Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 79.54% 79.56% +0.02%
==========================================
Files 38 38
Lines 14335 14335
==========================================
+ Hits 11403 11406 +3
+ Misses 2932 2929 -3 🚀 New features to boost your workflow:
|
That's the first version of GAP that shipped with utils >= 0.81 and groupoids >= 1.78.
Member
Author
|
Rebased this to verify that CI is now fully fixed with this patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's the first version of GAP that shipped with utils >= 0.81 and groupoids >= 1.78.
As such this should fix the
minimalCI job. The fix for the brokendeveljob is in PR #164.An alternative fix would be to keep the GAP bound, and instead install the latest utils and groupoids versions before starting the CI tests. But then we are no longer testing "can one just drop this package into an older GAP and it will work". But that's of course your choice :-)