Fix some issuse with manual examples - #164
Merged
Merged
Conversation
Member
Author
|
The motivation for this is that |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 38 38
Lines 14335 14335
=======================================
Hits 11403 11403
Misses 2932 2932 🚀 New features to boost your workflow:
|
- don't show `AutomorphismPermGroup` output as the listed generators can change when GAP changes its algorithms. The structure descriptions should be enough for a test. - fix a typo in an example - add missing `LoadPackage` output
fingolfin
force-pushed
the
mh/fix-examples
branch
from
August 15, 2026 12:58
c5276de to
87d2015
Compare
This was referenced Aug 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutomorphismPermGroupoutput as the listed generators can change when GAP changes its algorithms. The structure descriptions should be enough for a test.LoadPackageoutputThis fixes CI against GAP devel; see PR #166 for a fix that fixes the
minimalCI job.There are more things in the manual examples that do not actually work, e.g. there is an example using
DoublyRestrictedMappingwhich was removed in 2020. I would recommend extracting the manuals programmatically from the manual, only that can ensure the examples that are actually in the manual get tested properly.I'll provide a follow-up PR for this, but it reveals many more broken examples in the manual, so I can't finish it.