Repository navigation
fix(sdk): preserve Ledger V1 info during composition - #2016
Merged
Merged
Conversation
Dav-14
marked this pull request as ready for review
November 5, 2026 13:14
NumaryBot
approved these changes
Nov 5, 2026
NumaryBot
left a comment
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
flemzord
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
Ledger.V1.GetInfoin the composed SDK while retainingLedger.V3.Info. Stack #2007 removed the V1 operation when adding V3 because both useGET /api/ledger/_infowith different response models.Keep both source operations and let Speakeasy represent the collision with its native namespace fragments. Limit the existing fragment check to these two known entries and validate both operation IDs, tags and response references. No Ledger server or FCTL command change.
Evidence
Ledger.V1.GetInfois missing.go test -race ./cmd/ledger/... ./pkg/clientcontractpasses. Transport tests confirm neither a fragment nor%23reaches the HTTP path, and each method retains its response model.server=ledger,version=v2.4.17. V3 was tested with its response fixture; no live V3 qualification is claimed.validate-openapiassertions reject the previous composed artifact without V1 and pass the corrected one.just pre-commitpassed with publication disabled and the repository's pinned Speakeasy 1.759.2. The original workflow and workflow lock were restored afterward. Consumer generation used Speakeasy 1.757.1 / generator 2.866.2.git diff --checkpassed.Related: FCTL #204. Ledger query-schema decoding is a separate issue.
Merge Danger
Door: two-way
Blast Radius: SDK composition
HTTP routes and response contracts are unchanged. Composed path keys now distinguish V1 and V3 with namespace fragments; generated Go V3 method/signature/route remain intact and V1 is restored. Other OpenAPI consumers must support that representation. Speakeasy documents fragment paths for conflicting operations, with portability limitations outside its tooling.
This qualifies the Ledger info methods, not a full Stack SDK compatibility matrix. Wallets and Reconciliation import-only compile differences remain outside this PR. No merge, release, registry publication or deployment.