Skip to content

fix(openapi): remove obsolete Ledger schema and info assertions - #2018

Merged
Dav-14 merged 3 commits into
mainfrom
codex/generic-composition-validation
Nov 6, 2026
Merged

Dav-14 merged 3 commits into
mainfrom
codex/generic-composition-validation

Conversation

@Dav-14

@Dav-14 Dav-14 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove two Ledger-specific validation blocks from Stack composition:

 validate-openapi
-  legacy V2QueryParams.oneOf resource constants
-  hardcoded Ledger info fragment allowlist and V1/V3 response models

Ledger #2501 corrected the query-template contract: V2QueryParams is a flat object, so the old assertion fails with Cannot iterate over null. The info assertions couple Stack validation to exact Ledger operation IDs, tags and response model names. Keep the composition behavior that preserves both info operations; only their assertions are removed.

Other existing checks, including Ledger V2/V3 endpoint presence and Auth cleanup, remain unchanged. No overlays, component versions, generation configuration or HTTP contracts change.

Evidence

  • Before: release job fails on ledger_V2QueryParams.oneOf[].
  • After: nix develop --no-write-lock-file --command just validate-openapi passes against the freshly composed document used to qualify fctl feat: Numscript: allow 0 and 100 inclusive in portions: Update doc #204.
  • Full nix develop --no-write-lock-file --command just pre-commit passes: fresh downloads, OpenAPI composition/validation and event generation. Registry output was temporarily disabled locally; the committed workflow is unchanged.
  • git diff --check passes.
  • fctl feat: Numscript: allow 0 and 100 inclusive in portions: Update doc #204 was regenerated from that composition, its legacy schema adapter removed, and full CLI/SDK tests, pre-commit and CLI build passed locally. Those tests cover both Ledger info contracts and corrected query-template behavior.

Author analytical review: Principal Engineer PASS (no composition transformations changed); Product Engineer PASS (both info contracts preserved and fctl regression coverage passed); SRE PASS locally (full pre-commit passes). Remote release is not rerun or qualified.

Merge Danger

Door: two-way

Blast Radius: validation

Stack no longer checks the old query-param structure or exact Ledger info models/namespace-fragment allowlist. Composition and generated API behavior are unchanged. No merge, release or deployment is performed.

@NumaryBot NumaryBot added risk: medium NumaryBot classified this pull request as medium risk. bot-reviewed NumaryBot completed its review workflow for the current head. draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. labels Nov 6, 2026
@Dav-14 Dav-14 changed the title fix(openapi): keep composition validation component-agnostic fix(openapi): remove recent Ledger info assertions Nov 6, 2026
@Dav-14 Dav-14 changed the title fix(openapi): remove recent Ledger info assertions fix(openapi): remove obsolete Ledger schema and info assertions Nov 6, 2026
@Dav-14
Dav-14 marked this pull request as ready for review November 6, 2026 11:46
@NumaryBot NumaryBot added review-approved The NumaryBot review gate is satisfied for the current head. and removed draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. labels Nov 6, 2026

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required automated review completed with no remaining findings.

@Dav-14
Dav-14 merged commit a476c6c into main Nov 6, 2026
5 checks passed
@Dav-14
Dav-14 deleted the codex/generic-composition-validation branch November 6, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. risk: medium NumaryBot classified this pull request as medium risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants